Review: Needs Fixing
It lets some new menus appear. It doesn't crash after one morning of use.
But it doesn't display the list of documents in gedit's Documents menu.

in menuitem_notify_cb, you should test that the 'data' (recurse->context) 
pointer is still sane before de-referencing it. Also, if that structure has 
been disposed, you should wrap that with a closure and a trigger to unconnect 
the signal, or you'll end up with a signal call pointing to some random zone in 
memory.

-- 
https://code.launchpad.net/~bratsche/appmenu-gtk/dynamic-menu-fixes/+merge/28475
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.

_______________________________________________
Mailing list: https://launchpad.net/~ayatana-commits
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp

Reply via email to