Review: Needs Fixing * I think you need a g_list_free() in your finalize function to free the list data. * Usually when I free or unref things I set their variable to NULL. The reason is that if you add code later that uses it the symptom will be a segfault unstead of some weird memory rewrite. * Can we change the call to org_ayatana_WindowMenu_Registrar_register_window to be the async version so that apps don't hang if the registrar is in bad shape? I think if it returns an error we could just show the menubar back in the application. It shouldn't happen, so that seems like a safe fallback :) We don't want to be responsible for slowing app load time by too much :) * In unregister_application_windows I think it makes sense to call org_ayatana_WindowMenu_Registrar_unregister_window_async to clean up stuff on the indicator side as well. I don't think we really care if it errors :) -- https://code.launchpad.net/~bratsche/appmenu-gtk/dynamic-menu-fixes/+merge/28475 Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
_______________________________________________ Mailing list: https://launchpad.net/~ayatana-commits Post to : [email protected] Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
