Hi Johannes, Johannes Berg schrieb: > Ok first of all, please actually compile the tree after your changes. It > doesn't. When it does, please fix
I always do compile the compat-wireless-tree after changes I introduce, and it compiles without errors in the case of this mac80211:sta-remove patch. But as my build tree is based on the OpenWrt environment, it might be not 100% in sync. Could you be a bit more explicit where does it brake in you case (which function, driver...) ? > 1) line length in the commit log should be < 72 chars Will do so in v2. > 3) removal of an important comment in mac80211.h that I pointed out in > previous review >From your previous review:"...btw, you lost an important comment about it being NULL along the way" I guess you refer to the comment in mac80211.h, struct tx_info that I removed: - * The TX control's sta pointer is only valid during the ->tx call, - * it may be NULL. I am not sure what you want me to keep here as comment. As the sta pointer is moved into the new struct tx_control and the remaining pointers in the tx_info->control structure (vif, hw_key) are ALL only valid during the ->tx call and may be NULL. So I could think of adding a comment to tx_control about the sta been NULL, but anything more ? >> The tx-path of all affected drivers is restructured to respect the chaneged >> layout of struct ieee80211_tx_info. List of modified drivers: >> ath9k > > Please also remove the driver list. git can tell you the modified files > very easily. Will do so in v2. Greetings Thomas _______________________________________________ b43-dev mailing list b43-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/b43-dev
