On Sat, 10 May 2014 16:44:48 +0200 Rafał Miłecki <zaj...@gmail.com> wrote:
> config B43_BCMA
> - bool "Support for BCMA bus"
> - depends on B43 && (BCMA = y || BCMA = B43)
> - default y
> + bool
> + depends on B43
A dependency on a purely selected option is ignored.
So I think you can remove this one as well.
> config B43_SSB
> bool
> - depends on B43 && (SSB = y || SSB = B43)
> - default y
> + depends on B43
Same here.
> +choice
> + prompt "Supported bus types"
> + depends on B43
> + default B43_BCMA_AND_SSB
> +
> +config B43_BUSES_BCMA_AND_SSB
> + bool "BCMA and SSB"
> + depends on BCMA_POSSIBLE && SSB_POSSIBLE
I think this needs to be:
depends on (BCMA_POSSIBLE && (BCMA = y || BCMA = B43)) && (SSB_POSSIBLE
&& (SSB = y || SSB = B43))
to avoid the case where b43 is y and ssb or bcma is m.
Or did I miss something and this is caught elsewhere?
> + select B43_BCMA
> + select B43_SSB
> +
> +config B43_BUSES_BCMA
> + bool "BCMA only"
> + depends on BCMA_POSSIBLE
Similar here.
> + select B43_BCMA
> +
> +config B43_BUSES_SSB
> + bool "SSB only"
> + depends on SSB_POSSIBLE
And here.
> + select B43_SSB
> +
> +endchoice
--
Michael.
----
Please use PGP/GPG encryption.
Key-ID: F532BE1D908D8B0E
--------
signature.asc
Description: PGP signature
_______________________________________________ b43-dev mailing list b43-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/b43-dev
