On Thu, Sep 27, 2018 at 1:44 AM Christof Schulze <[email protected]> wrote: > > Juliusz, > > On Thu, Sep 27, 2018 at 12:37:01AM +0200, Juliusz Chroboczek wrote: > >> --- a/kernel_netlink.c > >> +++ b/kernel_netlink.c > > > >> +static int ipv4_metric = 0; > >> +static int ipv6_metric = 1024; > > > >That's exactly the wrong layer at which to do that. Policy should be > >happening at least 17 layers higher. > > > >What problem is that intended to solve?
It was 1/3 of the requirement to do atomic updates. > I also struggled with this patch. Those variables are set and used only > when an unreachable route is set. Couldn't we get rid of those two > variables again and just set RTN_UNREACHABLE and not modify the metric? I'm cool with that. > Christof > > -- > () ascii ribbon campaign - against html e-mail > /\ against proprietary attachments > > _______________________________________________ > Babel-users mailing list > [email protected] > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/babel-users -- Dave Täht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619 _______________________________________________ Babel-users mailing list [email protected] https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/babel-users
