On Friday 07 September 2007 13:35, Martin Simmons wrote:
> >>>>> On Fri, 7 Sep 2007 12:29:59 +0200, Kern Sibbald said:
> >
> > On Friday 07 September 2007 12:22, Martin Simmons wrote:
> > > >>>>> On Thu, 06 Sep 2007 20:09:15 -0400, Dan Langille said:
> > > >
> > > > Priority: normal
> > > > <[EMAIL PROTECTED]>,
> > > > <[EMAIL PROTECTED]>
> > > > Content-description: Mail message body
> > > >
> > > > On 6 Sep 2007 at 18:00, Scott Barninger wrote:
> > > > > On Thu, 2007-09-06 at 17:49 -0400, Dan Langille wrote:
> > > > > > > > Yeah, I saw that after posting this. Question is, should I
> > > > > > > > withdraw the 2.2.1 EL3 mysql package from sourceforge? And
> > > > > > > > long term, do I need to stop support for EL3 since it also
> > > > > > > > had the postgresql problem?
> > > > > > >
> > > > > > > Can you remind me what the PostgreSQL problem is?
> > > > > >
> > > > > > I think Scott refers to our upcoming use of PQescapeStringCon()
> > > > > > which is available only in PostgreSQL > 7.4
> > > > > >
> > > > > > > I think it is a very bad thing to move Bacula forward so fast
> > > > > > > that we start dropping somewhat older systems. So, I would
> > > > > > > really like to see the details of what is going wrong and try
> > > > > > > to come up with some work arounds.
> > > > >
> > > > > I refer to what I wrote after building the 2.2.1 packages, that on
> > > > > rhel3 the postgresql package fails to compile. You indicated I
> > > > > think that this was an issue with older postgresql versions?
> > > >
> > > > Ahh, related to PQputCopyData?
> > >
> > > Maybe a patch like this would help? I.e. only compile the postgresql
> > > batch code when enabled.
> > >
> > >
> > > Index: src/cats/postgresql.c
> > > ===================================================================
> > > --- src/cats/postgresql.c (revision 5487)
> > > +++ src/cats/postgresql.c (working copy)
> > > @@ -596,6 +596,8 @@
> > > return id;
> > > }
> > >
> > > +#ifdef HAVE_BATCH_FILE_INSERT
> > > +
> > > int my_postgresql_batch_start(JCR *jcr, B_DB *mdb)
> > > {
> > > char *query = "COPY batch FROM STDIN";
> > > @@ -799,4 +801,6 @@
> > > " (SELECT DISTINCT Name
> > > FROM batch) as a " " WHERE NOT EXISTS " " (SELECT
> > > Name FROM Filename WHERE Name = a.Name)"; +#endif /*
> > > HAVE_BATCH_FILE_INSERT */ +
> > > #endif /* HAVE_POSTGRESQL */
> >
> > Hmmm. I missed that and had assumed that the code was not compiled if it
> > was disabled. I think you have found the key problem in getting this to
> > be backward compatible.
> >
> > Have you tested that patch?
>
> It compiles cleanly on PostgreSQL 7.3.4 without --enable-batch-insert, but
> I have not tried running it. I have not tried compiling it with later
> versions of PostgreSQL or with --enable-batch-insert.
OK, great. That seems to be a big step forward. I'm going to integrate your
code and do a little testing on my system ...
>
> > What about MySQL?
>
> Sorry, I don't have MySQL, but I would guess that the same thing could can
> be in mysql.c. I'm not sure that will solve the problem being reported
> there though, because the code doesn't call any batch-specific MySQL APIs,
> just SQL statements.
OK, I'll check for the same thing on MySQL.
>
> > What about functions that may call the code from elsewhere in bacula?
>
> I guess they are all conditionalized with HAVE_BATCH_FILE_INSERT already,
> otherwise it would have failed to link.
Yes, all the developers are building/testing on relatively new systems -- mine
is probably the oldest one around, and it is CentOS 5.
We spent a lot of time testing batch insert and ensuring we could turn it off,
but I forgot to think about testing backward compatibility :-(
Thanks for the tips and help.
Kern
>
> __Martin
>
> > Eric, could you comment on this?
> >
> > Thanks.
> >
> > Regards,
> >
> > Kern
> >
> > > __Martin
> > >
> > > -----------------------------------------------------------------------
> > >-- This SF.net email is sponsored by: Splunk Inc.
> > > Still grepping through log files to find problems? Stop.
> > > Now Search log events and configuration files using AJAX and a browser.
> > > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > > _______________________________________________
> > > Bacula-devel mailing list
> > > [email protected]
> > > https://lists.sourceforge.net/lists/listinfo/bacula-devel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bacula-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
