On Friday 28 September 2007 04:02, Dan Langille wrote:
> I am proposing that I add a new configuration item: --archivedir.
>
> As part of my plans for world domination, I am amending the
>
> regression testing scripts as mentioned yesterday:
> > I plan to change the regression tests to allow more than one instance
> > to run concurrently on a given system.  This will allow two users to
> > test at the same time.  It will allow one person to run the tests
> > against MySQL and PostgreSQL in parallel instead of in serial.
>
> I've hit my first snag.  At the end of scripts/setup is the
> following:
>
>    cp -f bin/*.conf scripts
>
> The above takes the installed Bacula configuration files and keeps a
> copy of them for later use.  I think these are kept as known good
> starting points.  

Yes, that is done so that in a later test, backup-bacula-test I think, we can 
run with the "out-of-the-box" installed configuration files to ensure that 
Bacula just works.  Most of the regression tests have specialized conf files.

> The key configuration items that affect the 
> regression testing changes are:
>
> bacula-dir.conf contains Where = /tmp/bacula-restores
>
> bacula-sd.conf contains Archive Device = /tmp
>
> The values for this items are hardcoded in src/dird/bacula-
> dir.conf.in and src/stored/bacula-sd.conf.in (similarl entries exist
> within  src/win32).
>
> I think the cleanest way is to supply a new configuration item:
>
>   --archivedir=<path>

Yes, that is probably the best solution.  You might check and see if you can 
use --datadir since it is something that is implemented by default 
in ./configure, but I don't think Bacula uses it (must be confirmed).  That 
might avoid creating yet another configure option ...

>
> The above references entries in the .in configuration files would
> then look like this:
>
> bacula-dir.conf contains Where = @archivedir@/bacula-restores
>
> bacula-sd.conf contains Archive Device = @archivedir@
>
>
> The default value will be /tmp.
>
> Benefits I can see immediately are:
>
> 1 - lets me get on with the regression test changes.  ;)
> 2 - makes it easier for users/packagers to specify something other
> than /tmp
>
> Comments?

Sounds OK to me.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bacula-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bacula-devel

Reply via email to