Hello Martin, On Friday 23 November 2007 13:00, Martin Simmons wrote: ... > > I've found the problem that causes all of these config failures: nothing > includes sys/types.h in the config tests. > > It looks like other OSes (and older versions of Mac OS X) include this file > indirectly from some other header file, so it works by luck. > > Note that nothing defines HAVE_SYS_TYPES_H either, on any OS :-) > > This patch fixes configure, but it should obviously be done properly in the > autoconf: > > --- configure~ 2007-10-05 18:56:48.000000000 +0100 > +++ configure 2007-11-23 11:22:02.000000000 +0000 > @@ -19283,6 +19283,7 @@ > stdarg.h \ > stdlib.h \ > stdint.h \ > + sys/types.h \ > string.h \ > termios.h \ > termcap.h \ >
In looking at the code, I don't understand why adding sys/types.h at that point would correct the problem. The only reason for a header file to be included at that point is if we want HAVE_header_name defined, and no Bacula code explicitly checks on HAVE_SYS_TYPES_H ... as it is something defined by POSIX so it should exist on all platforms. Bacula explicitly includes sys/types.h all compiles within Bacula should work right without HAVE_SYS_TYPES_H defined. In fact, the majority of the header files in the list where you added sys/types.h are not really needed. I will make the change, but I just don't get it. The only way that I can understand why it would fix something is if ./configure itself needs HAVE_SYS_TYPES_H defined, and if that is the case, configure really should test itself. In any case, I cannot verify anything since there is no bug report on this, and thus I don't have the information I requested (specifically the configure output and the config.log file) Best regards, Kern ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
