On Friday 19 September 2008 00:07:21 Kern Sibbald wrote: > On Thursday 18 September 2008 22:46:04 John Huttley wrote: > > Actually I don't know what to think. > > > > its not, however, good press for bacula. > > > > No news may be good news, > > But some news is bad news! > > > > I do think that it needs to be fixed > > Quite honestly, I don't understand what needs to be fixed. As far as I know > the code in Bacula is correct and consistent as well as compatible with the > SQL standard, with possibly one small exception and that is that the > PostgreSQL tables are created all in lower case contrary to the other DB > table and the usage in the code.
By the way, it may not have been clear, but I am not criticising the Bacula PostgreSQL driver; it works perfectly fine. I am just mentioning that script that creates the tables is in a slightly different style from the rest of Bacula. This has never created any operation problems that I am aware of for Bacula. Kern > > >From what I understand of the SQL standard is that the table names are > > case > > independent, which is true in PostgreSQL, and not in MySQL and if that is > true the way they are written them in Bacula is in line with the standard. > > Concerning converting from one database to another, the explanation was not > clear enough for me to understand the problem. > > > Kern says that it could need a 'massive' rewrite, really, though I don't > > think so. > > It may be in lots of funny places but should be fixable with a simple > > search and replace. > > As I have mentioned above, as far as I am aware the current code is > correct, so there is no reason to make these massive changes, which would > only reduce the readability of the code. My experience is that such > massive changes always introduce errors so it is not something to be > lightly undertaken. > > > The real issue is the DB's may need a conversion script to change the > > names. This is not the sort of thing than can be done in point release. > > So much is obvious. > > Sorry, but I don't understand either of the first two sentences above. > > > The other thing I think is that the DB schema is umm... overly expedient. > > I also do not understand what "overly expedient" means. > > > I imagine speed was of critical importance when Kern was designing it. > > > > I do have a possible replacement, arising out work I did some years back. > > > > Let me start another thread.. > > OK. > > Regards, > > Kern > > > Dan Langille wrote: > > > John Huttley wrote: > > >> https://people.planetpostgresql.org/xzilla/index.php?/archives/360-Bac > > >>ul > > >> a,-Sqlite,-Postgres...-when-good-tools-go-horribly-horribly-wrong.html > > > > > > John: whenever people post a URL without commenting up on it, I always > > > ask them for their comments upon it. > > > > > > John: What do you think? > > > > > > and FYI, no, it is not bad SQL. > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's > > challenge Build the coolest Linux based applications with Moblin SDK & > > win great prizes Grand prize is a trip for two to an Open Source event > > anywhere in the world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > _______________________________________________ > > Bacula-devel mailing list > > Bacula-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/bacula-devel > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge Build the coolest Linux based applications with Moblin SDK & win > great prizes Grand prize is a trip for two to an Open Source event anywhere > in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Bacula-devel mailing list > Bacula-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bacula-devel ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
