Hello Graham,
Thanks for the patches. Since we are very close to releasing 3.0 at the
current time, I am holding all new features for examination shortly after the
release. If you haven't heard back from me within two weeks after the 3.0
release, please don't hesitate to ping me.
Best regards,
Kern
On Wednesday 18 March 2009 18:25:14 Graham Keeling wrote:
> On Sat, Mar 14, 2009 at 09:14:18PM +0100, Kern Sibbald wrote:
> > On Friday 13 March 2009 12:38:14 Graham Keeling wrote:
> > > Under the current design:
> > >
> > > The director connects to the storage daemon, and gets an
> > > sd_auth_key. The director then connects to the file daemon, and gives
> > > it the sd_auth_key with the 'jobcmd'.
> > > (restoring of files happens)
> > > The director does a 'wait_for_storage_daemon_termination()'.
> > > The director waits for the file daemon to indicate the end of the
> > > job.
> > >
> > > With my idea:
> > >
> > > The director connects to the file daemon.
> > > Then, for each storage daemon in the .bsr file... {
> > > The director connects to the storage daemon, and gets an
> > > sd_auth_key. The director then connects to the file daemon, and gives
> > > it the sd_auth_key with the 'storaddr' command.
> > > (restoring of files happens)
> > > The director does a 'wait_for_storage_daemon_termination()'.
> > > The director waits for the file daemon to indicate the end of the
> > > work on this storage.
> > > }
> > > The director tells the file daemon that there are no more storages to
> > > contact. The director waits for the file daemon to indicate the end of
> > > the job.
> > >
> > > As you can see, each restore between the file daemon and storage daemon
> > > is handled in the same way that it is currently handled, using the same
> > > method for authentication, except that the sd_auth_key is moved from
> > > the 'jobcmd' to the 'storaddr' command - where it logically belongs.
> >
> > I've added your request along with this clarification of the
> > implementation details to the projects list.
>
> Thank you.
>
> Attached are my patches, which apply to SVN as of the 18th of March 2009.
>
> The first patch file provides the functionality. Using old file daemons
> with the patched director code works fine for me.
> Currently, the message at the end of the job doesn't print a list of
> SDJobStatuses - it will print the last one that it got. I think this is
> fine, because if they all complete OK, it will print 'OK'. If one of them
> was not OK, the job would end before going onto the next storage, and
> you'll be given that last status.
>
> The second patch file tidies up large chunks of repeated code in
> src/dird/bsr.c into functions, which would be nice to have, regardless of
> the first patch.
>
> Graham.
------------------------------------------------------------------------------
_______________________________________________
Bacula-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
