On Thu, Jul 02, 2009 at 11:04:44AM +0200, Kern Sibbald wrote: > One thing that I don't understand is the need to build the Win64 version, > unless you have changes that you have not sent to the project. In that case, > I kindly ask you to tell me where I can find the changes so that I can > download them as the license requires. We will help you as much as we can, > and you in turn should help the project :-)
Hello, Yes, I have changes to do with making restore from multiple storage daemons work. I have already emailed the patch file to the list. You can find it here: http://markmail.org/message/t2te5k45qmbr7ssv The last time this was talked about, you gave me a list of six 'rather trivial but essential modifications' that you wanted me to do (which I am finally getting round to doing): > 1. You haven't followed the developers programming style guidelines > that are described in the developers manual. > > 2. In addition to the guidelines documented, we do not use // for comments > except in column 1 to turn code off. Please use C style comments. > > 3. We do not in general return -1 to mean true and zero to mean false. We use > true and false and a bool type. The exception to this is sometimes some > very low level routines that mimic the Unix OS call convention. > > 4. There aren't many comments. In particular, you have changed a major > flow within Bacula, so that merits at least some comments so that > the overall concept of what you are implementing can be easily > understood. I think the essential elements are in your email message > below, and it is just a matter of putting it in an appropriate place > in the code. > > 5. We will also need some user documentation that explains the ramifications > of this change for users. > > 6. Can you specify (email or possibly in the user documentation) what happens > if there is an error with one of the storage daemons -- i.e. does > everything shutdown correctly, and is it clear to the user which storage > daemon had the problem? > > I would appreciate it if you would make the above rather trivial but essential > modifications to your patch and then resend it to me. ------------------------------------------------------------------------------ _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
