On Sunday 29 November 2009 08:57:36 SF Markus Elfring wrote: > > > I suggest to change some identifiers that begin with two underscores or > > > an underscore and an uppercase letter. - How do you think about to use > > > the prefix "BACULA_" (instead of "_B") consistently? > > > > No, it is too clumbsy in my opinion. > > I prefer the correct application of the C naming convention. - Would you > like to look at the table 98.1 (page 219) from the book "The New C > Standard: An Economic and Cultural Commentary" by Derek M. Jones? > http://www.coding-guidelines.com/cbook/cbook1_2.pdf > > > > - Would you like to reduce the probability for name clashes by the > > > addition of GUIDs/UUIDs as suffixes in include guards? > > > > No. > > That's bad. - I find some identifiers from your header files too short. How > do you think about to make them really unique?
I would like to focus on adding new features and correcting bugs. We do between 10-15% cleanup of the code every version. However, I am not very interested in being pedantic and "correcting" things that are not impacting us or creating more work for the developers. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
