On Sunday 29 November 2009 12:13:22 SF Markus Elfring wrote: > > I haven't seen a patch, so I have no other comment. > > I find this reply strange. I repeat my update suggestion from the bug > report "Open issues in the configuration script" > (http://bugs.bacula.org/view.php?id=1415) once again as attachment here. > > Regards, > Markus
Hello, Well, this is a step in the right direction in the sense that it is a real patch. However, I am not too keen on these kinds of submissions, because it is a rather significant change with little or no benefit. That is it doesn't correct any real problem, and these kinds of changes bring a *high* probability of introducing errors, and most of the changes are not necessary and reduce readability at least in my opinion. Proof of the above is that your patch has at least one syntax error that I spotted that as far as I can tell means it will not "compile". The other problem is that you have introduced a change that forces the developers to work more. You have hard coded the Bacula version number into that file just at the place where the code takes a bit of pains to automatically configure itself. This means that for future versions, either we are forced to manually change the configure.in file, or there will be an inconsistency between the ./configure and the actual version. Needless to say, as it stands, I cannot apply the patch. Regards, Kern ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
