On Thursday 10 December 2009 08:02:27 Lucas B. Cohen wrote: > Hello Kern, > > Kern Sibbald wrote: > > Many thanks for your contribution. As you know, Eric has already > > committed it to the git repo :-) > > Indeed I've noticed. Does this imply proofreading and approval on Eric's > part ? > > Note that I've only slightly altered the sentence regarding btraceback > with which you seemed to disagree last week.
No, it does not imply complete approval. Eric does check the code/doc input, but for documentation, his mother tongue is not English so I will review it. I haven't yet reviewed the files, and I sometimes modify patches that come in to meet our standards (tabbing, variable naming, ... as well as our documentation style). By the way, I saw your note about git diff formats. What we have just decided (after monitoring what people are sending for a time) is that *if* the submitter is using git or is willing to use git, we will politely insist on "git format-patch" style. It is the best format for us because git knows the base and is able to apply the patch even if additional modifications have been made to the file since the submitter started working, and in that type of format, git also automatically commits with the correct author's name indicated, which we need for patch tracking. If the submitter doesn't know git or cannot learn it, we will accept "diff -u" patches. However, these are more work for us as there are sometimes conflicts, and we need to take extra care to ensure that the author's name is committed as well. git has been a steep learning curve for us (and for submitters) so there is no harm done with your patches. We are happy to get them. Since you have taken the trouble to learn git, for the next one, please do try to send it in git format-patch format. Thanks. Thanks again for your contribution and for sending in the FLA :-) Best regards, Kern ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
