So looking at the code, it looks like the RunScript variable %e will be "OK
-- with warnings" if status == JS_Warnings (never happens in current code),
or if status == JS_Terminated and errors > 0.
Additionally, there is a %E that contains the number of JobErrors
(undocumented in the Job Resource section of latest docs). Either of these
can get me what I need as far as my RunScript to update nagios.
I'd still like a way to indicate in the "status director" output that a job
was OK -- with warnings. I'm sure I can patch my local copy...maybe just a
custom entry in query.sql would suffice. It'd be nice to have a hook in the
code that "status director" runs to augment the job list query it runs.
Thanks for getting me looking at the code -- I can fix my nagios RunScript
now!
-Jonathan Hankins
On Fri, Sep 30, 2016 at 4:19 PM Marcin Haba <ganius...@gmail.com> wrote:
> Hello Jonathan,
>
> When you add checkfilechanges = yes then you change your question
> about jobstatus to question:
>
> Did all required data is backed up AND no file changed during backup?
>
> The "Access denied" means that something is currently impossible to
> backup and I think that it is something like "non-backup data". Bacula
> informs in job report when some data is impossible to backup.
>
> I understand your problem about Nagios. I tried Nagios long time ago
> and I remember that there are three states (info, warning, error). So,
> you have 'info' and 'error' but you don't have 'warning'.
>
> In web interfaces that I develop, I solve it by checking joberrors
> value from Job table in the Catalog. It is something like:
>
> if (jobstatus == 'T') {
> if (joberrors > 0) {
> jobstatus = 'W';
> }
> }
> .... use jobstatus.
>
> What do you think about it? Is it OK for you this getting joberrors
> value from the Catalog and check it?
>
> Thanks in advance for response.
>
> Best regards.
> Marcin Haba (gani)
>
> On 30 September 2016 at 23:00, Hankins, Jonathan
> <jhank...@homewood.k12.al.us> wrote:
> > So, I guess I'm curious about what causes ok with warnings vs. an error
> > status? If I have checkfilechanges = yes, and I get an error that a file
> > changed during backup, that is an ok with warnings status. Did the file
> > actually get backed up, or is it skipped?
> >
> > If a file gets an err access denied, does that still count as a warning,
> or
> > is that an error status?
> >
> > It seems to me that it'd be instructive to know in the console at a
> glance
> > if there were any warnings. Maybe the output of terminated jobs list
> could
> > include the JobErrors count? Or an asterisk next to the 'T' indicating
> > warnings, leaving the JobStatus set to 'T' for purposes of custom
> queries,
> > Nagios integration, etc.
> >
> > Speaking of Nagios, that's why I'd asked about it back in 2012. I wanted
> my
> > Nagios plug-in to return OK when JobStatus = T, WARNING when JobStatus =
> W,
> > and CRITICAL otherwise. That lead me to discover that JobStatus is never
> W.
> > I'm not at my office now, but I wonder if JobErrors is exposed in a
> > %variable, and if not, could it be? This would let us detect warnings in
> > Nagios plug-ins, etc. without changing JobStatus.
> >
> > I need to check if the docs still indicate that W is a possibile
> JobStatus.
> > If it is gone from the code, the docs need to match.
> >
> > Thanks,
> >
> > -Jonathan Hankins
> >
> >
> > On Fri, Sep 30, 2016, 3:16 PM Marcin Haba <ganius...@gmail.com> wrote:
> >>
> >> Hello,
> >>
> >> I would like to share with you my opinion about the jobstatus.
> >>
> >> For me the job status 'T' both for jobs completed OK and for jobs
> >> completed OK with warnings is quite OK. Everything depends on question
> >> on which the jobstatus 'T' has to give an answer. I think that the
> >> question here is: "Did all required data is backed up?" Answer: Yes
> >> ('T') or No ('E', 'e', 'f'...).
> >>
> >> It is the same story as a story about a guy that needed to travel from
> >> city A to city B. The goal in this travel is to come from city A to
> >> city B. Let's imagine that the guy started travel and he had some
> >> problems during travel but at the end he came to city B. Does the guy
> >> achieve what he needed?
> >>
> >> The same can be with the job. It doesn't matter how many times
> >> something goes wrong. The important for me is that data is consistent
> >> and everything what I needed is backed up.
> >>
> >> In my opinion, adding new 'W' jobstatus will introduce many problems
> >> in applications related to Bacula, like monitor software plugins
> >> (Nagios...), web interfaces (including mine Baculum), scripts written
> >> internally by admins, close source software that uses Bacula, ...etc.
> >>
> >> What do you think about it?
> >>
> >> Best regards.
> >> Marcin Haba (gani)
> >>
> >> On 30 September 2016 at 21:19, Hankins, Jonathan
> >> <jhank...@homewood.k12.al.us> wrote:
> >> > My jobs that complete "OK -- with warnings" with JobErrors > 0 always
> >> > have
> >> > JobStatus 'T'.
> >> >
> >> > I posted about this in 2012:
> >> >
> >> >
> https://www.mail-archive.com/bacula-devel@lists.sourceforge.net/msg07612.html
> >> >
> >> > No replies to that post. It looks like there was a commit in 2013:
> >> >
> >> >
> http://www.bacula.org/git/cgit.cgi/bacula/commit/?id=36b7c10b7fc787ab7b075f0b2521f7b20605ae6e
> >> > that disabled this functionality, because there was code that needed
> to
> >> > be
> >> > updated to say (JS_Terminated || JS_Warning). Not sure if this was
> ever
> >> > done? It looks like the DB gets 'T' stored as well, even though there
> >> > are
> >> > changelog comments indicating that the DB code has been updated to say
> >> > "JobStatus IN ('T', 'W') where necessary.
> >> >
> >> > The committed code/comment above doesn't seem to be in bacula anymore,
> >> > and I
> >> > am wondering if JobStatus = 'W' is supposed to be implemented yet?
> >> >
> >> > It would be nice to be able to easily tell from the status command
> that
> >> > a
> >> > job had warnings, instead of having to look through the job logs.
> >> >
> >> > Is this something that could be implemented if I was able/willing to
> >> > track
> >> > down the necessary changes and make a patch?
> >> >
> >> > Thanks,
> >> >
> >> > -Jonathan Hankins
> >> >
> >> >
> >> >
> >> >
> >> > This e-mail is intended only for the recipient and may contain
> confidential or proprietary information. If you are not the intended
> recipient, the review, distribution, duplication or retention of this
> message and its attachments is prohibited. Please notify the sender of this
> error immediately by reply e-mail, and permanently delete this message and
> its attachments in any form in which they may have been preserved.
> >> >
> >> >
> ------------------------------------------------------------------------------
> >> > Check out the vibrant tech community on one of the world's most
> >> > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> >> > _______________________________________________
> >> > Bacula-devel mailing list
> >> > Bacula-devel@lists.sourceforge.net
> >> > https://lists.sourceforge.net/lists/listinfo/bacula-devel
> >> >
> >>
> >>
> >>
> >> --
> >> "Greater love hath no man than this, that a man lay down his life for
> >> his friends." Jesus Christ
> >>
> >> "Większej miłości nikt nie ma nad tę, jak gdy kto życie swoje kładzie
> >> za przyjaciół swoich." Jezus Chrystus
> >
> >
> > This e-mail is intended only for the recipient and may contain
> confidential or proprietary information. If you are not the intended
> recipient, the review, distribution, duplication or retention of this
> message and its attachments is prohibited. Please notify the sender of this
> error immediately by reply e-mail, and permanently delete this message and
> its attachments in any form in which they may have been preserved.
>
>
>
> --
> "Greater love hath no man than this, that a man lay down his life for
> his friends." Jesus Christ
>
> "Większej miłości nikt nie ma nad tę, jak gdy kto życie swoje kładzie
> za przyjaciół swoich." Jezus Chrystus
>
--
This e-mail is intended only for the recipient and may contain confidential
or proprietary information. If you are not the intended recipient, the
review, distribution, duplication or retention of this message and its
attachments is prohibited. Please notify the sender of this error
immediately by reply e-mail, and permanently delete this message and its
attachments in any form in which they may have been preserved.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel
