|
On 10/01/2016 08:52 PM, Hankins,
Jonathan wrote:
I may poke around it a bit when I
have time. I'm not a C programmer, but the code is pretty clear
from what I've seen. If I can get something working, I'll send a
patch.
If you implement a patch, please submit it in a "feature request" in
the bugs database. If you do not, you might want to submit a
feature request without a patch because maybe in 10 years, I won't
have any more projects :-) (just kidding) maybe someday, I will
just feel like doing a few small projects :-)
Best regards,
Kern
Thanks!
-Jonathan Hankins
Jonathan,
That might be a good "compromise". The only thing that
doesn't appeal to me is adding yet another directive. I
have been trying hard to avoid adding new directives since
Bacula now has so many directives, I am starting to forget
what does what :-(.
If someone sent me a patch, I think I would apply it.
However, Bacula already warns on errors -- they generate
an error message. We should think about it a bit, but a
better choice for the directive name, might be
AllowWarningStatus ... or maybe you have a better idea
such as just "WarningStatus = yes/no". I might even be
inclined to make it default yes if all the regression
scripts run with it on (very unlikely I think).
Best regards,
Kern
On 10/01/2016 06:32 PM, Hankins, Jonathan wrote:
Kern, what are your
thoughts about, in an effort to phase in W job status
without breaking people's stuff, a
per-fileset/job/client/whatever directive such as
WarnOnError, default = no, and some logic in the
JobStatus code to write W to the database/wherever it
needs to go, in cases where the user has explicitly
asked for it, and T otherwise? I can imagine use cases
where errors on one fileset don't matter but on others,
you'd like it reflected in the db.
-Jonathan Hankins
And I think that I
confused myself. I'll check, but I think I saw that
the director code for show dir does print ok with
warnings, and not just ok, on jobs with warnings
(by looking at JobErrors). I was confusing that
output with list jobs, which shows JobStatus, and
thus indicates T even on jobs with warnings. It may
be that it also shows a column for JobErrors...my
brain was just expecting to see a W. I've read
through the code enough to understand the issues and
expected behavior now. I will do a patch to add %E
to the documentation when I get a minute. That gives
me what I need as far as Nagios runscripts.
I agree, suddenly
having W where there hasn't been one before in the
db might break people's Custom scripts and queries.
It looks like bacula has been adapted for it
everywhere that I looked though.
Thanks,
-Jonathan Hankins
I have planned a JobStatus == 'W'
for quite some time, but I am very concerned
that implementing it will break many existing
environments, scripts/programs that look at
the output. Consequently, it remains
suspended.
Best regards,
Kern
On 09/30/2016 09:19 PM, Hankins, Jonathan
wrote:
My jobs that complete
"OK -- with warnings" with JobErrors >
0 always have JobStatus 'T'.
I posted about this in 2012: https://www.mail-archive.com/bacula-devel@lists.sourceforge.net/msg07612.html
No replies to that
post. It looks like there was a commit in
2013: http://www.bacula.org/git/cgit.cgi/bacula/commit/?id=36b7c10b7fc787ab7b075f0b2521f7b20605ae6e that
disabled this functionality, because there
was code that needed to be updated to say
(JS_Terminated || JS_Warning). Not sure if
this was ever done? It looks like the DB
gets 'T' stored as well, even though there
are changelog comments indicating that the
DB code has been updated to say "JobStatus
IN ('T', 'W') where necessary.
The committed
code/comment above doesn't seem to be in
bacula anymore, and I am wondering if
JobStatus = 'W' is supposed to be
implemented yet?
It would be nice to
be able to easily tell from the status
command that a job had warnings, instead
of having to look through the job logs.
Is this something
that could be implemented if I was
able/willing to track down the necessary
changes and make a patch?
Thanks,
-Jonathan Hankins
This e-mail is intended only for the recipient and may contain confidential or proprietary information. If you are not the intended recipient, the review, distribution, duplication or retention of this message and its attachments is prohibited. Please notify the sender of this error immediately by reply e-mail, and permanently delete this message and its attachments in any form in which they may have been preserved.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel
This e-mail is intended only for the recipient and may contain confidential or proprietary information. If you are not the intended recipient, the review, distribution, duplication or retention of this message and its attachments is prohibited. Please notify the sender of this error immediately by reply e-mail, and permanently delete this message and its attachments in any form in which they may have been preserved.
This e-mail is intended only for the recipient and may contain confidential or proprietary information. If you are not the intended recipient, the review, distribution, duplication or retention of this message and its attachments is prohibited. Please notify the sender of this error immediately by reply e-mail, and permanently delete this message and its attachments in any form in which they may have been preserved.
|
