On 2017-06-11 16:23, Kern Sibbald wrote:
Hello,
Versions of Bacula BETA 7.9.0, 1, 2, and 3, all had what I thought was
a trivial change to the DIR<->SD protocol. It turned out to be a
rather significant change that affected the FD as well. So if you
were running version 7.9.0, 1, 2, or 3 you would possibly see messages
that said that it was a "Malformed message: ...". These messages were
essentially harmless but annoying especially because the messages were
never properly dispatched.
I believe that I have now fixed all these problems with version
7.9.4., which is currently released on www.bacula.org. Since I am not
at home, this is an expedited release without updating the
ReleaseNotes.
Sorry for the problems, and thanks to those who reported them.
Just got around to building this on Solaris 10.
It still has the bad code in lz4.c:
Compiling lz4.c
"lz4.c", line 174: Error: Syntax error in pragma.
"lz4.c", line 174: Error: Missing ')' in #pragma.
"lz4.c", line 174: Error: Syntax error in pragma.
"lz4.c", line 182: Error: Syntax error in pragma.
"lz4.c", line 182: Error: Missing ')' in #pragma.
"lz4.c", line 182: Error: Syntax error in pragma.
6 Error(s) detected.
Here is a context diff for the fix, as I can't see how to turn off lz4
in configure:
===============================================================
bacula-7.9.4/src/lib $ diff -c lz4.c.bad lz4.c
*** lz4.c.bad Fri Jun 16 17:27:26 2017
--- lz4.c Fri Jun 16 17:27:43 2017
***************
*** 171,177 ****
#endif
#if !defined(LZ4_FORCE_UNALIGNED_ACCESS) && !defined(__GNUC__)
! # pragma pack(push, 1)
#endif
typedef struct _U16_S { U16 v; } _PACKED U16_S;
--- 171,177 ----
#endif
#if !defined(LZ4_FORCE_UNALIGNED_ACCESS) && !defined(__GNUC__)
! # pragma pack(1)
#endif
typedef struct _U16_S { U16 v; } _PACKED U16_S;
***************
*** 179,185 ****
typedef struct _U64_S { U64 v; } _PACKED U64_S;
#if !defined(LZ4_FORCE_UNALIGNED_ACCESS) && !defined(__GNUC__)
! # pragma pack(pop)
#endif
#define A64(x) (((U64_S *)(x))->v)
--- 179,185 ----
typedef struct _U64_S { U64 v; } _PACKED U64_S;
#if !defined(LZ4_FORCE_UNALIGNED_ACCESS) && !defined(__GNUC__)
! # pragma pack()
#endif
#define A64(x) (((U64_S *)(x))->v)
===============================================================
Cheers,
Gary B-)
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel
