Hello Gary,

OK, I have now pushed another fix, which I am pretty confident will fix your build problem on Solaris 10 without breaking any other architecture. Please pull the latest version of Bacula from the git repo. It is version 7.9.6 19 June 2017. As previously mentioned, you will need to do a proper ./configure prior to the make.

I would appreciate it if you would let me know if it works "out of the box" now.

Thanks for reporting this and for giving me rapid feedback.

Best regards,

On 06/19/2017 05:09 AM, Gary R. Schmidt wrote:
Hi Kern,

On 2017-06-19 02:55, Kern Sibbald wrote:
Hello Gary,

Could you send me a diff -u of your patch or simply the patched lz4.c
file.  I think I did the inverse of what is needed -- that is I
removed the pack() on Solaris 10.  If I did get it backwards, the code
will obviously not work.

diff -u:
bacula-7.9.4/src/lib $ diff -u lz4.c.bad lz4.c
--- lz4.c.bad   Fri Jun 16 17:27:26 2017
+++ lz4.c       Fri Jun 16 17:27:43 2017
@@ -171,7 +171,7 @@

 #if !defined(LZ4_FORCE_UNALIGNED_ACCESS) && !defined(__GNUC__)
-#  pragma pack(push, 1)
+#  pragma pack(1)

 typedef struct _U16_S { U16 v; } _PACKED U16_S;
@@ -179,7 +179,7 @@
 typedef struct _U64_S { U64 v; } _PACKED U64_S;

 #if !defined(LZ4_FORCE_UNALIGNED_ACCESS) && !defined(__GNUC__)
-#  pragma pack(pop)
+#  pragma pack()

 #define A64(x) (((U64_S *)(x))->v)

And lz4.c file attached as well.

                Gary    B-)

Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Bacula-devel mailing list

Reply via email to