|
Hello Sven Thanks for your patches. The first two look fine, but there is a problem with the third patch for configure. The problem is that if anyone builds starting from scratch from source, configure will be overwritten when "make configure" is called. This is because configure is "compiled" from the file <bacula>/autoconf/configure.in. As a consequence, any changes made to <bacula>/configure must only be done by modifying the configure.in file. Can you come back to me and indicate what changes you would make to autoconf/configure.in? Best regards, Kern On 03/04/2018 07:45 PM, Sven Hartge
wrote:
Hello! The Debian lintian package checker found a warning about a cross-compile unsafe way to find pkg-config: https://lintian.debian.org/tags/autotools-pkg-config-macro-not-cross-compilation-safe.htmlThe attached Patch 0001 fixes this by using the appropriate PKG_PROG_PKG_CONFIG macro. Patches 0002 and 0003 refresh aclocal.m4 to include the needed macros from pkg.m4 and then refresh the configure script, but it is well possible this is done at another place during the Bacula release process. In that case those patches are of course not needed. I have so far implemented this change in a non-releases branch of the Debian packaging repository and test-built packages from it. My testing so far has not revealed any negative changes. All in all, pkg-config is only used during the building of "bat" so the impact is low. Grüße, Sven. |
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
