The following works for me (I tested it with 5 rather than 100): diff --git a/bacula/src/console/console.c b/bacula/src/console/console.c index f70ee8500f..3894c15225 100644 --- a/bacula/src/console/console.c +++ b/bacula/src/console/console.c @@ -936,7 +936,7 @@ void trapctlc() } #ifdef HAVE_READLINE -static int histfile_size=0; +static int histfile_size=100; #endif static int console_update_history(const char *histfile)
__Martin >>>>> On Wed, 26 Feb 2020 13:00:24 +0100, Kern Sibbald said: > > Hello Martin, > > Actually, I am not sure of anything. This was a patch that Eric made to > the Enterprise Edition. I never use readline so I am very unsure of the > ramifications of this change. It appears that in the Enterprise > Edition, they created a directive to set the history file size, and most > likely with that, the problem you mention is avoided. > > I can easily make a guess of what to do, but would you show me the exact > change that you think is appropriate? > > Thanks, > > Kern > > On 2/26/20 12:33 PM, Martin Simmons wrote: > > Hi Kern, > > > > The 9.6.1 code in the repo compiles now, but the history file is always > > empty. > > > > The problem is that histfile_size=0 causes nlines to be 0 in all cases. > > Maybe > > you want histfile_size=100? > > > > __Martin > > > > > >>>>>> On Wed, 26 Feb 2020 12:04:14 +0100, Kern Sibbald said: > >> > >> > >> > >> > >> > >> Hello Wanderlei, > >> > >> Sorry for the problem. It was an incomplete patch that caused > >> build failures when using readline. > >> > >> Please try version 9.6.1 which is now pushed to the repo. > >> Hopefully this will fix the problem. > >> > >> I will make the official release announcement later today. > >> > >> Best regards, > >> > >> Kern > >> > >> > >> > >> > >> On 2/25/20 6:58 PM, Wanderlei Huttel > >> wrote: > >> > >> > >> > >> cite="mid:cadoapsdmblwnbrgzk9de4vrr0hew_wcd-yqbxmepoggajq2...@mail.gmail.com"> > >> > >> > >> Hello Kern > >> > >> > >> > >> I'm running a Debian 9 > >> > >> > >> > >> ================================= > >> > >> > >> > >> No LSB modules are available. > >> > >> Distributor ID: Debian > >> > >> Description: Debian GNU/Linux 9.12 (stretch) > >> > >> Release: 9.12 > >> > >> Codename: stretch > >> > >> ================================= > >> > >> > >> > >> I've downloaded the source code from bacula git. > >> > >> > >> > >> I've already had Branch-9.4, so I only updated > >> > >> > >> > >> git pull (for updating) > >> > >> git checkout Branch-9.6 ( to change the Branch) > >> > >> git pull (for updating again) > >> > >> > >> > >> My ./configure is the following > >> > >> ================================= > >> > >> #!/bin/bash > >> > >> #CFLAGS="-g -O2 -Wall" \ > >> > >> ./configure \ > >> > >> --enable-smartalloc \ > >> > >> --with-postgresql \ > >> > >> --with-db-user=bacula \ > >> > >> --with-db-password=bacula \ > >> > >> --with-db-port=5432 \ > >> > >> --with-openssl \ > >> > >> --with-readline=/usr/include/readline \ > >> > >> --with-dump-email= > >> moz-do-not-send="true">em...@domain.com.br \ > >> > >> --with-job-email= > >> moz-do-not-send="true">em...@domain.com.br \ > >> > >> --sysconfdir=/etc/bacula \ > >> > >> --sbindir=/usr/bin \ > >> > >> --sbindir=/usr/sbin \ > >> > >> --with-scriptdir=/etc/bacula/scripts \ > >> > >> --with-plugindir=/etc/bacula/plugins \ > >> > >> --with-pid-dir=/etc/bacula/working \ > >> > >> --with-subsys-dir=/etc/bacula/working \ > >> > >> --with-working-dir=/etc/bacula/working \ > >> > >> --with-bsrdir=/etc/bacula/bootstrap \ > >> > >> --with-basename=bacula \ > >> > >> --with-hostname=192.168.1.1 \ > >> > >> --with-systemd \ > >> > >> --disable-conio \ > >> > >> --disable-nls \ > >> > >> --with-logdir=/var/log/bacula > >> > >> > >> ================================= > >> > >> > >> > >> > >> > >> data-smartmail="gmail_signature"> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> Best regards > >> > >> > >> > >> > >> color="#0b5394">Wanderlei > >> Hüttel > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> Em ter., 25 de fev. de 2020 às > >> 14:38, Kern Sibbald < > >> moz-do-not-send="true">k...@sibbald.com> escreveu: > >> > >> > >> 0.8ex;border-left:1px solid > >> rgb(204,204,204);padding-left:1ex"> > >> > >> > >> Hello Wanderlei, > >> > >> I was just about to announce the release today, but from > >> what you report, it looks like something went wrong. > >> > >> Can you tell me from where you downloaded the source and > >> send me the ./configure line that you used? > >> > >> I am going to try to find the problem with the source (I > >> cannot reproduce it here), then I will look at the manual. > >> > >> Best regards, > >> > >> Kern > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> On 2/24/20 12:34 PM, Wanderlei Huttel wrote: > >> > >> > >> > >> Hello > >> > >> > >> > >> I saw today, that Bacula 9.6.0 was released! > >> > >> > >> > >> I've tried to to compile, bu I've receiving an > >> error message in console.c. > >> ================================================= > >> > >> > >> Compiling console.c > >> > >> /usr/src/bacula/bacula/libtool --silent --tag=CXX > >> --mode=link /usr/bin/g++ -L/usr/include/readline > >> -L../lib -L../cats -o bbconsjson bbconsjson.o > >> console_conf.o \ > >> > >> -lreadline -lhistory -lbaccfg -lbac -lm > >> -lpthread -ldl -ldl \ > >> > >> -lssl -lcrypto > >> > >> In file included from ../bacula.h:165:0, > >> > >> from console.c:27: > >> > >> console.c: In function ‘int > >> console_update_history(const char*)’: > >> > >> console.c:948:21: error: ‘histfile_size’ was not > >> declared in this scope > >> > >> int nlines = MAX(histfile_size - > >> history_lines_added, 0); > >> > >> ^ > >> > >> ../bc_types.h:246:21: note: in definition of macro > >> ‘MAX’ > >> > >> #define MAX(a, b) ((a) > (b) ? (a) : (b)) > >> > >> ^ > >> > >> Makefile:144: recipe for target 'console.o' failed > >> > >> make[1]: *** [console.o] Error 1 > >> > >> make[1]: Leaving directory > >> '/usr/src/bacula/bacula/src/console' > >> > >> > >> > >> > >> > >> ====== Error in /usr/src/bacula/bacula/src/console > >> ====== > >> > >> > >> > >> > >> ================================================= > >> > >> > >> > >> > >> > >> Another problem is about the encoding of the manual . > >> It look like that the wrong encoding begin to happen > >> in all 9.X version! > >> > >> > >> > >> > >> > >> > >> > >> src="cid:part4.6F68DA29.62E7D268@sibbald.com" > >> alt="image.png" class="" width="383" height="476"> > >> > >> > >> > >> > >> > >> > >> > >> > >> src="cid:part5.26B3018A.C30BB506@sibbald.com" > >> alt="image.png" class="" width="476" > >> height="265"> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> Best regards > >> > >> > >> > >> > >> style="font-size:12.8px"> > >> color="#0b5394">Wanderlei > >> Hüttel > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> _______________________________________________ > >> Bacula-devel mailing list > >> Bacula-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/bacula-devel > >> > >> > >> > >> > >> > >> > >> > >> > >> > _______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
