On 2020-02-27 07:20, Kern Sibbald wrote: > Hello Gary, > > Sorry if a fix you submitted was not picked up -- it is probably my > fault. I have been doing an extraordinary amount of traveling, which > means that sometimes emails get overlooked. > > Do you consider your fix better than what is currently implemented?
My personal feeling is that one fix is as good as the other. It's "If this is not yet defined, define it" vs. "If compiling on a version that is known not to define this, define it". But that one warning is a minor contributor to the noise. The "hides virtual function ..." warnings contribute far more noise to the build, but I freely admit I do not know nearly enough C++ to know how to fix them. (Though it occurs to me that I know a guy who is REALLY good with C++. I'll ask whether he has a few spare cycles.) But the gripping hand, again, is that all of these are only warnings that appear to be harmless, and only on Solaris which is a relatively uncommonly used platform these days. It would absolutely be a good thing to fix them, but there are doubtless higher priorities that provide more benefit to more users. -- Phil Stracchino Babylon Communications ph...@caerllewys.net p...@co.ordinate.org Landline: +1.603.293.8485 Mobile: +1.603.998.6958 _______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
