On 3/1/21 6:00 AM, Radosław Korzeniewski wrote: > Hello Phil, > > Bacula configure script is checking for typeof() and sets HAVE_TYPEOF if > found. I think the proper fix should use: > > #ifdefHAVE_TYPEOF > ... > #else > ... > #endif > > This scheme is used in Bacula in a few places already. Could you add > this issue to bugs.bacula.org <http://bugs.bacula.org>, please.
Will do. > Also, the last line of src/filed/suspend.h does not have a newline, > > Is it a real problem for SDS? No, it's just a warning, but as Gary points out, it *is* a malformed file and the compiler *should* complain about it. It's the only case in which I NOTICED a no-newline warning, but there may have ben others I missed. I can provide a full list of all of the warnings if you'd like. > and building 11.0.x in the Solaris Developer Studio requires that > CFLAGS/CPPFLAGS include -features=zla to allow declaring zero-length > arrays. > > Could you point to the code where you have this, I think it should be > fixed as the new c11 standard forbids zero length arrays explicitly. I'm not sure what you're asking here. I added it to my CFLAGS/CPPFLAGS for configure: ./configure --prefix=/opt/bacula --with-dump-email=r...@caerllewys.net --with-job-email=r...@caerllewys.net --with-smtp-host=smtp.caerllewys.net --with-subsys-dir=/opt/bacula/var --with-working-dir=/opt/bacula/var --enable-build-stored --disable-build-dird --enable-smartalloc --with-mysql=/opt/mysql/mysql CC=/opt/suncc/bin/CC CFLAGS='-fast -xarch=generic -xtarget=generic -xcache=generic -m64 -features=zla' CPPFLAGS='-fast -xarch=generic -xtarget=generic -xcache=generic -m64 -features=zla' CXX=/opt/suncc/bin/CC CXXFLAGS='-fast -march=native -mfpmath=sse -pipe -m64' LDFLAGS="-m64" The file in which it came up as an issue is here: Compiling append.c "tape_dev.h", line 70: Warning: tape_dev::get_hi_addr hides the virtual function DEVICE::get_hi_addr(long). "tape_dev.h", line 70: Warning: tape_dev::get_low_addr hides the virtual function DEVICE::get_low_addr(long). "tape_dev.h", line 70: Warning: tape_dev::get_full_addr hides the virtual function DEVICE::get_full_addr(unsigned, unsigned). "tape_dev.h", line 70: Warning: tape_dev::get_full_addr hides the virtual function DEVICE::get_full_addr(long). "cloud_dev.h", line 132: Warning: cloud_dev::get_hi_addr hides the virtual function DEVICE::get_hi_addr(long). "cloud_dev.h", line 132: Warning: cloud_dev::get_low_addr hides the virtual function DEVICE::get_low_addr(long). "cloud_dev.h", line 132: Warning: cloud_dev::get_full_addr hides the virtual function DEVICE::get_full_addr(unsigned, unsigned). "aligned_dev.h", line 142: Warning: aligned_dev::get_hi_addr hides the virtual function DEVICE::get_hi_addr(long). "aligned_dev.h", line 142: Warning: aligned_dev::get_low_addr hides the virtual function DEVICE::get_low_addr(long). "aligned_dev.h", line 142: Warning: aligned_dev::get_full_addr hides the virtual function DEVICE::get_full_addr(unsigned, unsigned). "win_file_dev.h", line 30: Warning: device hides DEVICE::device. "prepare.h", line 37: Error: An array cannot have zero size unless you use the option -features=zla. 1 Error(s) and 11 Warning(s) detected. make[1]: *** [append.o] Error 2 make[1]: Leaving directory `/netstore/src/bacula-11.0.1/src/stored' So the problem is in prepare.h, but it only actually comes into play in append.c. (Or at least, FIRST comes into play in append.c.) -- Phil Stracchino Babylon Communications ph...@caerllewys.net p...@co.ordinate.org Landline: +1.603.293.8485 Mobile: +1.603.998.6958 _______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
