Hello, pon., 1 mar 2021 o 15:49 Phil Stracchino <ph...@caerllewys.net> napisał(a):
> On 3/1/21 6:00 AM, Radosław Korzeniewski wrote: > > Hello Phil, > > > > Bacula configure script is checking for typeof() and sets HAVE_TYPEOF if > > found. I think the proper fix should use: > > > > #ifdefHAVE_TYPEOF > > ... > > #else > > ... > > #endif > > > > This scheme is used in Bacula in a few places already. Could you add > > this issue to bugs.bacula.org <http://bugs.bacula.org>, please. > > > Will do. > Thank you. > > > > Also, the last line of src/filed/suspend.h does not have a newline, > > > > Is it a real problem for SDS? > > > No, it's just a warning, but as Gary points out, it *is* a malformed > file and the compiler *should* complain about it. It's the only case in > which I NOTICED a no-newline warning, but there may have ben others I > missed. I can provide a full list of all of the warnings if you'd like. > I asked if this is a problem which could break the compilation. I fully understand the warning. I fixed it all in the development repository, so it should be available for the next major revision or patchset if Eric cherry-pick it to the current branch. > > and building 11.0.x in the Solaris Developer Studio requires that > > CFLAGS/CPPFLAGS include -features=zla to allow declaring zero-length > > arrays. > > > > Could you point to the code where you have this, I think it should be > > fixed as the new c11 standard forbids zero length arrays explicitly. > > I'm not sure what you're asking here. I'm asking you to disclose the warning/error you have because the array is zero-length as you've mentioned the issue without any details. > "prepare.h", line 37: Error: An array cannot have zero size unless you > use the option -features=zla. > 1 Error(s) and 11 Warning(s) detected. > make[1]: *** [append.o] Error 2 > make[1]: Leaving directory `/netstore/src/bacula-11.0.1/src/stored' > > So the problem is in prepare.h, but it only actually comes into play in > append.c. (Or at least, FIRST comes into play in append.c.) > Thanks, this is exactly what I asked. best regards -- Radosław Korzeniewski rados...@korzeniewski.net
_______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
