On Sun, 2010-10-10 at 21:22 +0300, Vlad Dragu wrote:
> > 1. Should add references to parents instead of duplicating values
> > (for example Site.owner_id and Site.owner_session should be a
> > reference to the instantiated objects, not the values
> > themselves
> >
> [vlad] i added a owner property of type User to the site class, modified
> the get_owner & set_owner functions to use the user type
> [vlad] modified the owner_session property and made it of game_session
> type; modified the set_owner_session and get_owner_session so that they
> use the game_session type as param
Sounds good.
Would be good to add some references in the Mission class that would
allow the mission scripters to easily access the important objects,
like:
* session => GameSession
* site => GameSession->site
* user => GameSession->user
> [vlad] the php version would need to be at least 5.2.0 to have support
> for the datetime object
It's good imho - the current version in Debian is 5.2.6 - would be good
to add this requirement to the INSTALL file though.
All the rest of the comments and modifications you've made are good!
The rest of the last set of changes is:
* Add: a reference to the MissionEngine in GameSession will
probably be needed
* Mission->get_mission_name() and
Mission->get_mission_description() not useful (just directly
access the property)
* Mission->replenish_hackscan_points() move to User (accessed by
the missions through Mission->user->replenish_hack_scan_points()
* The inheritance arrows should all be the same (cf Observable,
Observer, ActionLogger)
* Remove Site.set_url()
* Change get_*() and set_*() methods to direct attributes access
* Merge PlayerStats in SiteCollection and expand player_stats
array as attributes. (also remove the sites_till_level_up()
method from User, since it's accessed through SiteCollection)
Xavier.
_______________________________________________
Farsides mailing list - [email protected]
Wiki: http://farsides.com/
List: http://farsides.com/ml/
Forum: http://farsides.com/forum/
Ideas: http://farsides.com/ideas/
Chat: http://farsides.com/chat/
