Re: [Farsides] Review UML schema

[Vlad Dragu]

Would be good to add some references in the Mission class that would
allow the mission scripters to easily access the important objects,
like:
       * session =>  GameSession
       * site =>  GameSession->site
       * user =>  GameSession->user

[vlad] done

[vlad] the php version would need to be at least 5.2.0 to have support
for the datetime object

It's good imho - the current version in Debian is 5.2.6 - would be good
to add this requirement to the INSTALL file though.

[vlad] i modified the install file and pushed to the repository

All the rest of the comments and modifications you've made are good!

[vlad] :) thank you

The rest of the last set of changes is:
       * Add: a reference to the MissionEngine in GameSession will
         probably be needed

[vlad] done

       * Mission->get_mission_name() and
         Mission->get_mission_description() not useful (just directly
         access the property)

[vlad] i used the same approach as forall other similar properties (magic __get and __set)

       * Mission->replenish_hackscan_points() move to User (accessed by
         the missions through Mission->user->replenish_hack_scan_points()

[vlad] done

       * The inheritance arrows should all be the same (cf Observable,
         Observer, ActionLogger)

[vlad] done

       * Remove Site.set_url()

[vlad] done

       * Change get_*() and set_*() methods to direct attributes access

[vlad] i implemented an abstract class that defines the __get and __set methods (it's called Object Properties). all classes that need to make properties available to the outside will inherit from this class

       * Merge PlayerStats in SiteCollection and expand player_stats
         array as attributes. (also remove the sites_till_level_up()
         method from User, since it's accessed through SiteCollection)

[vlad] done

[vlad] i also removed the Tag list class and added the tag_list array as a private property for the site class

uml_schema_2010.10.10_v2.pdf
Description: Adobe PDF document

_______________________________________________
Farsides mailing list - b...@hackit.cx

Wiki:  http://farsides.com/
List:  http://farsides.com/ml/
Forum: http://farsides.com/forum/
Ideas: http://farsides.com/ideas/
Chat:  http://farsides.com/chat/