On Fri, 2010-12-24 at 18:48 +0200, Vlad Dragu wrote: > today i worked on the implementation of trust gauges. > I took a broader approach that will give us some flexibility when > working on the section later.
Very nice work Vlad! It's really cool : ) I had a look at the code, and I don't have much to criticize this time ;p It fits well the architecture, and it's good to have a starting point for the admin. Maybe the only point would be related to tests. It's missing the unit tests, and the upgrade script apparently missed the two new tables again, I had to copy them manually from db_hackit.sql (not sure what's wrong with your mysqldiff - did you try to test it manually to see if he was producing the expected results?). David -- I don't have the issue with the external sites that you have. Are you sure this was happening before merging Vlad's code? How did you do the upgrade? > Merry Christmas!! Merry Christmas too : ) Thanks for the work! Xavier. _______________________________________________ Farsides mailing list - [email protected] Wiki: http://farsides.com/ List: http://farsides.com/ml/ Forum: http://farsides.com/forum/ Ideas: http://farsides.com/ideas/ Chat: http://farsides.com/chat/
