Hi, Here is the log of the chatroom at http://farsides.com/chat/ (or irc://irc.freenode.net/#farsides) for the 2011-08-06.
2011-08-06 00:00:48+0000 mtyaka (mtyaka) is now online 2011-08-06 04:43:30+0000 mtyaka (mtyaka) is now online 2011-08-06 06:33:03+0000 antoviaque1 (antoviaque1) is now online 2011-08-06 06:39:33+0000 antoviaque (antoviaque) is now online 2011-08-06 09:06:54+0000 <mtyaka> hi antoviaque! 2011-08-06 09:07:08+0000 <antoviaque> hi mtyaka : ) 2011-08-06 09:07:18+0000 <antoviaque> how are you? 2011-08-06 09:07:30+0000 <mtyaka> i'm good 2011-08-06 09:07:30+0000 <antoviaque> I guess you're without tasks, right? 2011-08-06 09:08:04+0000 <antoviaque> or were you able to figure out what to do? 2011-08-06 09:08:27+0000 <mtyaka> yes, i thought i'd do #292 and #293 2011-08-06 09:08:39+0000 <mtyaka> is that ok? 2011-08-06 09:08:57+0000 <mtyaka> it seems the png sprites aren't quite ready yet 2011-08-06 09:08:58+0000 <antoviaque> ah cool, I was worried about that 2011-08-06 09:09:18+0000 <mtyaka> so i'll do the invitations first 2011-08-06 09:09:26+0000 <antoviaque> mtyaka: yep - actually I think they are now, we were able to find a way to export 2011-08-06 09:09:43+0000 <antoviaque> but best to discuss with arbrandes when he comes 2011-08-06 09:09:50+0000 <antoviaque> Glad you started on this : ) 2011-08-06 09:10:06+0000 <mtyaka> i have a couple of questions about the invitation dialog... 2011-08-06 09:10:21+0000 <mtyaka> yestarday we added a confirmation text 2011-08-06 09:10:51+0000 <mtyaka> like this: http://tickets.farsides.com/issues/326 2011-08-06 09:11:54+0000 <mtyaka> after you input some emails and click the submit button, the invitations get sent and you see the confirmation text instead of the textarea 2011-08-06 09:12:16+0000 <antoviaque> ah cool, much better 2011-08-06 09:12:30+0000 <antoviaque> thanks for thinking of this :) 2011-08-06 09:12:32+0000 <mtyaka> my question is - shouldn't you be able to invite more people, after you pressed the button the first time? 2011-08-06 09:12:45+0000 <antoviaque> true 2011-08-06 09:12:54+0000 <antoviaque> what do you suggest? 2011-08-06 09:14:02+0000 <mtyaka> perhaps next to the confirmation text, there should be a button "Invite more" ? 2011-08-06 09:14:09+0000 <antoviaque> sounds good to me 2011-08-06 09:14:21+0000 <mtyaka> it would restore the dialog to the original appearance 2011-08-06 09:14:44+0000 <mtyaka> ok, so i'll do something like that 2011-08-06 09:14:52+0000 <antoviaque> yep - perfect 2011-08-06 09:14:55+0000 <antoviaque> thanks mtyaka 2011-08-06 09:15:07+0000 <mtyaka> no problem 2011-08-06 09:15:24+0000 <mtyaka> another thing i noticed is that in the old version, the submit button was initially disabled 2011-08-06 09:15:40+0000 <mtyaka> and only after you input some text, it gets enabled 2011-08-06 09:15:45+0000 <antoviaque> yep 2011-08-06 09:16:29+0000 <mtyaka> this was easier in the old version because it was handled with classes - now we are using actual images for the buttons which makes the JS code a bit nastier 2011-08-06 09:16:40+0000 <mtyaka> but that's not a big problem 2011-08-06 09:16:50+0000 <mtyaka> i don't think there is an image for the disabled state, though 2011-08-06 09:17:03+0000 <antoviaque> if it creates complications, you can drop it for now I think 2011-08-06 09:17:51+0000 <antoviaque> the main goal being to test the improvements in accessibility, it isn't on the critical path 2011-08-06 09:18:00+0000 <mtyaka> ok, i'll keep the logic that adds the class and later we can do something else with it 2011-08-06 09:18:02+0000 <mtyaka> ok 2011-08-06 09:18:08+0000 <antoviaque> perfect - thx! 2011-08-06 09:18:28+0000 <mtyaka> one more thing - the facebook button 2011-08-06 09:18:42+0000 <mtyaka> do we already have functionality for that? 2011-08-06 09:18:50+0000 <mtyaka> or is that something that still needs to be implemented 2011-08-06 09:19:53+0000 <antoviaque> it is implemented but commented out 2011-08-06 09:20:16+0000 <antoviaque> I think you can try to activate it, it may work - but if it doesn't don't spend time on it, we'll see later too 2011-08-06 09:20:30+0000 <mtyaka> ok 2011-08-06 09:20:49+0000 <antoviaque> have to go out for 1 hour - do you need anything else before I leave? 2011-08-06 09:21:15+0000 <mtyaka> i'd like to agree about the estimates 2011-08-06 09:21:24+0000 <antoviaque> ah, yep! 2011-08-06 09:21:29+0000 <antoviaque> what do you have in mind? 2011-08-06 09:21:54+0000 <mtyaka> 2hrs for #292 and 3hrs for #293 2011-08-06 09:21:56+0000 <mtyaka> is that ok? 2011-08-06 09:22:30+0000 <antoviaque> sounds good - thanks for checking : ) 2011-08-06 09:22:44+0000 <mtyaka> thanks for agreeing :) 2011-08-06 09:22:48+0000 <antoviaque> hehe ;p 2011-08-06 09:22:51+0000 <antoviaque> ok, bbl! 2011-08-06 09:28:03+0000 dachary (dachary) is now online 2011-08-06 09:58:36+0000 <antoviaque> re 2011-08-06 10:04:31+0000 tartarugafeliz (tartarugafeliz) is now online 2011-08-06 10:39:02+0000 dachary (dachary) is now online 2011-08-06 10:40:29+0000 dachary (dachary) is now online 2011-08-06 12:22:35+0000 tartarugafeliz (tartarugafeliz) is now online 2011-08-06 12:26:42+0000 dachary (dachary) is now online 2011-08-06 12:39:39+0000 dachary (dachary) is now online 2011-08-06 12:39:43+0000 dachary (dachary) is now online 2011-08-06 13:12:40+0000 mtyaka (mtyaka) is now online 2011-08-06 13:30:06+0000 <mtyaka> antoviaque: i'm finished my tasks 2011-08-06 13:30:14+0000 <antoviaque> mtyaka: cool : ) 2011-08-06 13:30:29+0000 <mtyaka> i spent some unpleasant moments fighting with IE 2011-08-06 13:30:34+0000 <antoviaque> :/ 2011-08-06 13:30:55+0000 <mtyaka> appearantly, it is a very bad idea to give a textarea background-color of transparent in IE (even IE9!) 2011-08-06 13:30:56+0000 <antoviaque> I don't remember any pleasant moment with IE actually ;p 2011-08-06 13:31:07+0000 <mtyaka> LOL 2011-08-06 13:31:18+0000 <antoviaque> crazy bunch : ) 2011-08-06 13:32:25+0000 <mtyaka> do you mind if i bump the time on #293 for half an hour? I ended up using more time than expected. 2011-08-06 13:32:40+0000 <antoviaque> no problem 2011-08-06 13:32:52+0000 <mtyaka> thanks! 2011-08-06 13:33:31+0000 <antoviaque> I wonder how much IE cost in people's time and money, in total - must be quite impressive : ) 2011-08-06 13:34:08+0000 <mtyaka> heh, yeah... 2011-08-06 13:34:18+0000 <antoviaque> for your next tasks, are all the tasks left about the png animations? 2011-08-06 13:34:30+0000 <mtyaka> in my short career as a web developer i have probably spent months just fighting with IE 2011-08-06 13:34:40+0000 <antoviaque> not suprising yep 2011-08-06 13:34:47+0000 <mtyaka> about the tasks... i went through them 2011-08-06 13:35:04+0000 <antoviaque> (if yes you'll need to talk with arbrandes, not sure where he is with it - otherwise you can just pick one of the other tasks if it's not taken by anyone) 2011-08-06 13:35:14+0000 <mtyaka> i think they are all blocked either on png sequences or design, except the "go to vote" confirmation box 2011-08-06 13:35:41+0000 <antoviaque> ah, cool - I don't think arbrandes took that one? 2011-08-06 13:36:06+0000 <mtyaka> i don't think so... 2011-08-06 13:37:11+0000 <mtyaka> it is two tasks #316 and #317 2011-08-06 13:37:22+0000 <mtyaka> first one is HTML + CSS, second one Javascript 2011-08-06 13:38:12+0000 <antoviaque> ok - if good for you, I let you attribute themselves to yourself & estimate 2011-08-06 13:39:05+0000 <mtyaka> good for me 2011-08-06 13:47:33+0000 <mtyaka> antoviaque: there are two issues in the tracker that i believe have been resolved together with #293 - the outline and resize handle around textareas in Chrome (those are #287 and #288) 2011-08-06 13:47:52+0000 * antoviaque looking 2011-08-06 13:47:56+0000 <mtyaka> i tried to mark them as resolved, but seem to have messed up somehow... 2011-08-06 13:49:13+0000 <mtyaka> i managed to put #287 into "accepted" state, but now cannot change the state anymore 2011-08-06 13:49:46+0000 <antoviaque> mtyaka: there must be a bug in the permissions setup, I'll have a look 2011-08-06 13:49:59+0000 <antoviaque> for cases like this, the best is to mark as duplicate 2011-08-06 13:50:11+0000 <antoviaque> and put them as invalid 2011-08-06 13:50:22+0000 <antoviaque> this way only the ticket containing the patch will reach review 2011-08-06 13:50:30+0000 <mtyaka> ah, ok 2011-08-06 13:50:31+0000 <antoviaque> I've done this already for those two : ) 2011-08-06 13:50:36+0000 <mtyaka> yes, that makes sense 2011-08-06 13:50:40+0000 <mtyaka> great, thanks! 2011-08-06 13:50:41+0000 <antoviaque> and now looking at the permissions 2011-08-06 13:50:45+0000 <antoviaque> yw : ) 2011-08-06 13:56:15+0000 arbrandes (arbrandes) is now online 2011-08-06 13:56:27+0000 <antoviaque> hi arbrandes! 2011-08-06 13:56:34+0000 <mtyaka> hey arbrandes! 2011-08-06 13:56:37+0000 <arbrandes> morning dudes! :) 2011-08-06 13:56:40+0000 <antoviaque> :) 2011-08-06 14:01:27+0000 <mtyaka> antoviaque: same thing with #292 and #293 - they are in the "accepted" state and i don't get an option to change it. 2011-08-06 14:02:09+0000 <antoviaque> let me see 2011-08-06 14:03:13+0000 <arbrandes> mtyaka, so, we can't have textarea's with transparent background in IE? Pffft, Microsoft... 2011-08-06 14:03:28+0000 <antoviaque> mtyaka: ahahah => "Xavier agrees because he has fond memories of IE :)" ;p 2011-08-06 14:03:37+0000 <antoviaque> ok, put both in ready for review 2011-08-06 14:03:46+0000 <mtyaka> antoviaque: thanks! 2011-08-06 14:04:26+0000 <antoviaque> I'll give the option of putting accepted into specified or invalid, to not block in the future 2011-08-06 14:05:24+0000 <mtyaka> arbrandes: with the transparent background it is not possible to give textarea focus in IE - clicking on it does nothing, also cursor doesn't change into caret when hovering over it.... fun stuff 2011-08-06 14:06:01+0000 <mtyaka> i have seen many IE bugs but this one was new fro me 2011-08-06 14:06:07+0000 <mtyaka> s/fro/for/ 2011-08-06 14:07:53+0000 <arbrandes> Amazing... it's a wonder anything from Microsoft works at all. :/ 2011-08-06 14:13:39+0000 <arbrandes> mtyaka, are you going to work on any task from #206? I couldn't quite finish the animations; will need new pngs from tartarugafeliz 2011-08-06 14:14:40+0000 <arbrandes> However, I'm thinking I'll commit what I have so work can continue 2011-08-06 14:39:25+0000 <mtyaka> arbrandes: i noticed that the pngs aren't quite ready, so I thought i'd work on the "go to vote" dialog - #316 and #317 2011-08-06 14:39:38+0000 <mtyaka> does that suit you? 2011-08-06 14:40:53+0000 <arbrandes> sure, go ahead :) 2011-08-06 14:41:24+0000 <mtyaka> ok :) 2011-08-06 14:52:09+0000 <mtyaka> arbrandes: i'm not sure i understand how to know when a player has joined a game. I guess we'll be polling the server? 2011-08-06 14:53:16+0000 <mtyaka> is the code that does that already written or is this something that we still need to implement? 2011-08-06 14:53:55+0000 <arbrandes> mtyaka, funny you should ask, I'm trying to find that out right now, hehehe 2011-08-06 14:54:04+0000 <mtyaka> :) 2011-08-06 14:54:06+0000 <arbrandes> mtyaka, dachary says it's in place 2011-08-06 14:54:19+0000 <arbrandes> let's look for it 2011-08-06 14:54:23+0000 <arbrandes> if you find it, tell me :) 2011-08-06 14:54:27+0000 <arbrandes> I'll do the same 2011-08-06 14:54:43+0000 <mtyaka> in place on the server or also on the client side? 2011-08-06 14:55:12+0000 <arbrandes> good question, don't know 2011-08-06 14:56:01+0000 <mtyaka> there's the $.cardstories.poll function that calls game_or_lobby as a callback... unfortunately i don't know what neither $.cardstories.game nor $.cardstories.refresh_lobby does... 2011-08-06 14:56:04+0000 <arbrandes> What i know is that there's a "long poll" going on most of the time, I think we're supposed to use it. But this is just a guess, haven't actually looked at the code. 2011-08-06 14:57:04+0000 <mtyaka> ok, will take a closer look 2011-08-06 14:58:09+0000 <arbrandes> I'm looking too, if you have any insights, post'em ;) 2011-08-06 14:58:55+0000 <arbrandes> mtyaka, there might be relevant info here, too:http://wiki.farsides.com/w/Card_Stories_-_Client_Documentation 2011-08-06 15:01:25+0000 <arbrandes> more specifically: http://wiki.farsides.com/w/Card_Stories_-_Client_Documentation#Long_polling 2011-08-06 15:01:37+0000 <mtyaka> yup, reading it now... 2011-08-06 15:11:04+0000 dachary (dachary) is now online 2011-08-06 15:13:12+0000 <arbrandes> mtyaka, I think this is what we need: http://wiki.farsides.com/w/Card_Stories_-_Webservice_Documentation#Invitation_state 2011-08-06 15:13:39+0000 <arbrandes> an array with players is returned 2011-08-06 15:14:03+0000 <arbrandes> it remains to be seen if it is returned immediately when a player joins 2011-08-06 15:15:21+0000 <mtyaka> arbrandes: interesting 2011-08-06 15:16:11+0000 <mtyaka> i'll have to give up for today, need to get some sleep 2011-08-06 15:17:24+0000 <arbrandes> mtyaka, sure, if I find out how to do it, I'll post it on your ticket. 2011-08-06 15:17:41+0000 <mtyaka> have fun and good luck reverse engineering the long polling technique :) 2011-08-06 15:17:45+0000 <mtyaka> arbrandes: awesome, thanks! 2011-08-06 15:17:51+0000 <arbrandes> :) 2011-08-06 15:17:51+0000 <mtyaka> bye dudes :) 2011-08-06 15:18:08+0000 <dachary> I can answer questions regarding long poll if you need 2011-08-06 15:18:17+0000 <arbrandes> dachary, hey man, coo 2011-08-06 15:18:19+0000 <arbrandes> cool 2011-08-06 15:18:27+0000 <mtyaka> hi dachary 2011-08-06 15:18:56+0000 <arbrandes> I'm currently trying to find out when and if the author's client is notified when an invited player joins the game. 2011-08-06 15:19:15+0000 <arbrandes> I'm currently looking at the "participate" method in the server 2011-08-06 15:19:22+0000 <dachary> he is notified 2011-08-06 15:19:22+0000 <arbrandes> (currently, currently... :P) 2011-08-06 15:19:43+0000 <dachary> the general logic is that all clients are notified as soon as something changes in the game state 2011-08-06 15:20:39+0000 <dachary> if you're a player and you're notified that another player changed his mind about the card he picked, the display won't change because you don't get to see the actual card. But you're notified anyway. 2011-08-06 15:20:53+0000 <dachary> That keeps the logic simple and you don't get to wonder if / when who is notified of what. 2011-08-06 15:21:17+0000 <arbrandes> Ok, so, correct me if I'm wrong: 1) author invites somebody, and sits at the long poll. 2011-08-06 15:21:18+0000 <dachary> arbrandes: does that make sense ? 2011-08-06 15:21:47+0000 <arbrandes> 2) long poll returns when somebody joins, with a list of players (in the case of the first one, only one player) 2011-08-06 15:22:06+0000 <dachary> correction: 2011-08-06 15:22:13+0000 <arbrandes> 3) The stack would go something like: game_or_lobby -> game -> invite -> invitation_owner 2011-08-06 15:22:31+0000 <arbrandes> good, correction, go ahead :) 2011-08-06 15:22:42+0000 <dachary> 2) long poll returns when somebody joins with *nothing* (actually just the timestamp of the last change) 2011-08-06 15:22:58+0000 <arbrandes> ah 2011-08-06 15:23:01+0000 <dachary> 3) the client is expected to ask for the game state and redisplay 2011-08-06 15:23:33+0000 * arbrandes looking at the code 2011-08-06 15:24:08+0000 <dachary> arbrandes: it is very coarse grained. There is only one way to ask about the current state of the game, it's to ask for *all* the information. 2011-08-06 15:25:20+0000 <arbrandes> found it, the "game" method asks for it after the poll returns (and a game is running). Is this correct? 2011-08-06 15:25:43+0000 <dachary> correct 2011-08-06 15:27:30+0000 <dachary> this keeps the logic simple, at the expense of sending more data. But the complete information regarding a game is so small that it does not matter much. The communication latency will almost always be longer than the transfer time of the payload. 2011-08-06 15:27:54+0000 <arbrandes> in our case, data[0].state would be "invitation", I suppose, which would call "invitation_owner". There I can use game.players at my leisure to display joining animation. Sounds good! 2011-08-06 15:28:16+0000 <arbrandes> dachary, agreed, there's not much info, from what I've seen 2011-08-06 15:31:35+0000 <arbrandes> I would still need to save each player's position, but I don't think that'll be too hard. I need to take a better look at the data structure that is returned. 2011-08-06 15:31:42+0000 <arbrandes> Anyway, thanks for the help, dachary 2011-08-06 15:33:04+0000 <dachary> the order in which the players are returned won't change from one call to the next. You can refer to the board display partly implemented for the vote state to see how I did it. 2011-08-06 15:33:42+0000 <dachary> one call => one call of the game function 2011-08-06 15:34:45+0000 <arbrandes> hmmm, wasn't aware you had started on it. great tip, thanks 2011-08-06 15:35:10+0000 <dachary> it was back in june 2011-08-06 15:36:09+0000 <dachary> rows = yield self.service.db.runQuery("SELECT player_id, cards, picked, vote, win FROM player2game WHERE game_id = ? ORDER BY player_id", [ self.get_id() ]) 2011-08-06 15:36:19+0000 <dachary> in cardstories/cardstories/game.py 2011-08-06 15:37:07+0000 <dachary> I'm not correct in saying the order will be consistent 2011-08-06 15:38:30+0000 <arbrandes> hmm, yes, if a player whose id is lower than another joins, he/she will come first 2011-08-06 15:38:51+0000 <dachary> yes 2011-08-06 15:39:06+0000 <dachary> I think this should be fixed server side because it's much less pain 2011-08-06 15:39:34+0000 <arbrandes> Yes, otherwise we'd have to save that information somewhere in the DOM 2011-08-06 15:41:46+0000 <arbrandes> player2game would need a new field, wouldn't it? 2011-08-06 15:41:52+0000 <arbrandes> to store the order 2011-08-06 15:44:57+0000 <dachary> arbrandes: http://pastebin.com/X56ZBsCm 2011-08-06 15:45:02+0000 <dachary> I think that would do the trick 2011-08-06 15:45:17+0000 <dachary> indeed 2011-08-06 15:48:54+0000 <arbrandes> awesome, dachary's patch-o-matic saves the day again! ;) Thanks a lot 2011-08-06 15:49:31+0000 <dachary> arbrandes: I wrote the test. Would you be so kind as to remind me which tickets this relates to ? 2011-08-06 15:51:03+0000 <arbrandes> This is going to affect a bunch of tickets, but the first related one is http://tickets.farsides.com/issues/303. Maybe I should open a new ticket just for this, since it's important. 2011-08-06 15:54:03+0000 <arbrandes> dachary, http://tickets.farsides.com/issues/327 2011-08-06 15:54:46+0000 <dachary> dam, I goofed and pushed #307 instead of #327 2011-08-06 15:55:33+0000 <arbrandes> there's still time to ammend it and push --force, i don't think anybody pulled in the last 5 seconds, hehehe 2011-08-06 15:56:13+0000 <dachary> fixing the ticket 2011-08-06 15:56:25+0000 <dachary> I won't re-push 2011-08-06 15:57:32+0000 <dachary> arbrandes: http://tickets.farsides.com/issues/327 waiting for your review ;-) 2011-08-06 15:58:41+0000 <arbrandes> hehehehehe, looking :) 2011-08-06 16:01:08+0000 <arbrandes> dachary, looks good, the test is particularly enlightening to me 2011-08-06 16:01:43+0000 <dachary> arbrandes: how do you mean ? cut/paste + swap line ? ;-) 2011-08-06 16:03:07+0000 <arbrandes> dachary, it's just that I hadn't looked at the webservice tests yet. This particular one shows me the a-b-c for inviting a player, that's all. :) 2011-08-06 16:03:40+0000 <arbrandes> (aside from the plugin tests, I mean) 2011-08-06 16:04:36+0000 <dachary> :-D the tests are the documentaiton 2011-08-06 16:05:28+0000 <arbrandes> definitely :) 2011-08-06 16:11:43+0000 <arbrandes> bbl. As always, your help was invaluable dachary, thanks 2011-08-06 18:26:46+0000 arbrandes (arbrandes) is now online 2011-08-06 20:05:40+0000 dachary (dachary) is now online 2011-08-06 23:42:39+0000 mtyaka (mtyaka) is now online _______________________________________________ Farsides mailing list - [email protected] Wiki: http://farsides.com/ List: http://farsides.com/ml/ Forum: http://farsides.com/forum/ Ideas: http://farsides.com/ideas/ Chat: http://farsides.com/chat/
