Hi Vlad,

I went through some of the alpha1.2 changes, and I have one main comment
so far, with the leaderboard class.

There is the same type of issue as described in #611815 with the
structure of the object. You directly access the user attributes through
a SQL query in the leaderboard definition, outside of the definition of
a User class - which means every time you will need this information,
you will execute a similar query and manually get things like
stripslashes($rez[$i]['nickname']), which leads to code duplication and
more maintenance later on. 

Have a look at
http://onlamp.com/pub/a/php/2004/08/05/dataobjects.html?page=1 

Xavier.
_______________________________________________
Hackit Bar mailing list - [email protected]

Wiki:  http://community.hackit.cx/
List:  http://community.hackit.cx/ml/
Forum: http://community.hackit.cx/forum/
Ideas: http://community.hackit.cx/ideas/
IRC:   irc://irc.freenode.net/#politis

Reply via email to