Hi Xavier, Let me see if I understand correctly: should I refactor all code written so far and use the DB_DataObject pear package instead of the queries I normally use?
If so, when should we schedule this task? I believe it will take a significant amount of time on its own. What should be my priorities for the few days remaining in this week? I see 3 directions in which I could be going: Finish alpha 1.2 (the only task left is the ajaxim implementation – if it goes smoothly, it should not take long) Go through the bugs in alpha 1.1 (I got the phpdocumentor to fix and to see if I can find something with the owa / awstats discrepancies) Start the implementation of dataobjects. Let me know, Thanks Vlad From: [email protected] [mailto:[email protected]] On Behalf Of Xavier Antoviaque Sent: Wednesday, August 04, 2010 1:56 PM To: [email protected] Subject: [HackIt Bar] [Code] Alpha 1.2 - Review 1 Hi Vlad, I went through some of the alpha1.2 changes, and I have one main comment so far, with the leaderboard class. There is the same type of issue as described in #611815 <https://bugs.launchpad.net/hackit/+bug/611815> with the structure of the object. You directly access the user attributes through a SQL query in the leaderboard definition, outside of the definition of a User class - which means every time you will need this information, you will execute a similar query and manually get things like stripslashes($rez[$i]['nickname']), which leads to code duplication and more maintenance later on. Have a look at http://onlamp.com/pub/a/php/2004/08/05/dataobjects.html?page=1 Xavier.
_______________________________________________ Hackit Bar mailing list - [email protected] Wiki: http://community.hackit.cx/ List: http://community.hackit.cx/ml/ Forum: http://community.hackit.cx/forum/ Ideas: http://community.hackit.cx/ideas/ IRC: irc://irc.freenode.net/#politis
