On Tue, 2010-08-31 at 10:11 +0200, david blanchard wrote:
> I created the UPDATE and RELEASE_NOTES files and updated them to the
> repository.
Thanks! Good to have this, it will be helpful to follow what's going on
with the code : )
A few issues through:
* The structure of the release notes file doesn't follow the
requirements (please read
http://community.hackit.cx/wiki/Requirements_and_deliverables_for_patch_submission#Release_notes
more carefully)
* It's missing the Changelog section (cf
https://secure.wikimedia.org/wikipedia/en/wiki/Changelog for the
format)
* UPDATE file is good, but you need to include the SQL code in a
separate file that can be loaded directly from command-line to
ease the upgrade process, just like you did for alpha1.1 (put
files like db_hackit_update_alpha1.1-alpha1.2.sql in a sql/
subdirectory - would be good to move all the .sql files there
actually to avoid a mess the root directory)
> * simpletest : could not generate report locally
> * jscoverage -> 97%
I could run simpletests, it's at 99%, and the lines that aren't tested
correspond to cases we have discussed already - all good on that side.
However, running the tests still generates a lot of E_NOTICE errors, and
I don't remember what we said about this anymore - I've closed the bug
#605623, but I can't remember why anymore. Do you remember Vlad?
> Tests: Windmill tests
> run without error (run
> all & verify created
> for new features)
> OK
>
>
>
>
>
>
> All tests pass fine
>
>
Have new windmill test been created for the new features?
> * Missions : NOK
> Not on my local branch yet
Hum, is this part of alpha1.2? I thought it was for alpha2.0?
> Code review: Read code for each change & comment
This was done progressively, and so far it's ok, the necessary changes
will apply starting with next release. I still need to read the latest
commits for alpha1.2, but I don't expect difficulties.
> Code review: Check
> other deliverable
> requirements
> (documentation, OO,
> commit isolation...)
> ?
>
>
>
>
>
>
> [Xav]
>
Documentation is still not ok - did you had a look at it already Vlad?
Xavier.
_______________________________________________
Hackit Bar mailing list - [email protected]
Wiki: http://community.hackit.cx/
List: http://community.hackit.cx/ml/
Forum: http://community.hackit.cx/forum/
Ideas: http://community.hackit.cx/ideas/
IRC: irc://irc.freenode.net/#politis
