> From: Oleksij Rempel <[email protected]> > > > > diff --git a/drivers/nor/cfi_flash.h b/drivers/nor/cfi_flash.h > > index 8f818ba..6c7cac4 100644 > > --- a/drivers/nor/cfi_flash.h > > +++ b/drivers/nor/cfi_flash.h > > @@ -295,7 +295,11 @@ static inline u64 flash_read64(void *addr) > > */ > > static inline uchar *flash_make_addr (struct flash_info *info, > > flash_sect_t sect, uint offset) > > { > > +#ifdef CONFIG_DRIVER_CFI_BANK_SHIFT_1 > > + return ((uchar *) (info->start[sect] + (offset * info->portwidth << > > 1))); > > +#else > > return ((uchar *) (info->start[sect] + (offset * info->portwidth))); > > +#endif > > } > > Please make this a runtime option configurable via platform data. Making > this a compile time option is not so nice. > Or could this be automatically detected?
Do not treat my opinion as solution but I think better if we make this option as integer as make it available always. In this case we can avoid using #ifdef. --- _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
