On Tue, May 21, 2013 at 08:28:10AM +0200, Sascha Hauer wrote:
> Sebastian,
>
> > +static int armada_370_xp_init_soc(void)
> > {
> > unsigned long phys_base, phys_size;
> >
> > - mvebu_init_clocks();
> > + armada_370_xp_init_clocks();
> > add_generic_device("mvebu-timer", DEVICE_ID_SINGLE, NULL,
> > - MVEBU_TIMER_BASE, 0x30, IORESOURCE_MEM,
> > - NULL);
> > - mvebu_memory_find(&phys_base, &phys_size);
> > + (unsigned int)ARMADA_370_XP_TIMER_BASE, 0x30,
> > + IORESOURCE_MEM, NULL);
> > + armada_370_xp_memory_find(&phys_base, &phys_size);
> > arm_add_mem_device("ram0", phys_base, phys_size);
> > + armada_370_xp_add_uart();
>
> How do you want to support a board which uses another UART instead of
> uart0 when you call this from SoC code?
Ok, I see. You use CONFIG_MVEBU_CONSOLE_UART to determine an UART base.
What's the rationale for doing this? We don't want to have compile time
decisions for things we know at runtime.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
