On Sun, 29 Mar 2015 04:07:23 +0800 Jean-Christophe PLAGNIOL-VILLARD <[email protected]> wrote:
> please write a better commit The commit is made with 'git commit --fixup', so commit message is autogenerated. The patch is send with autosquashing in mind. Please read http://fle.github.io/git-tip-keep-your-branch-clean-with-fixup-and-autosquash.html for details. > > it’s a coding style issue not a fixup > and here more a typo > > Fixup means a BUG > > Best Regards, > J. > > On Mar 28, 2015, at 12:23 AM, Antony Pavlov <[email protected]> wrote: > > > > --- > > commands/hashsum.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/commands/hashsum.c b/commands/hashsum.c > > index e2dc70e..8d3694f 100644 > > --- a/commands/hashsum.c > > +++ b/commands/hashsum.c > > @@ -36,7 +36,7 @@ static int do_hash(char *algo, int argc, char *argv[]) > > size_t keylen = 0; > > int opt, ret; > > > > - while((opt = getopt(argc, argv, "h:")) > 0) { > > + while ((opt = getopt(argc, argv, "h:")) > 0) { > > switch(opt) { > > case 'h': > > key = optarg; > > -- > > 2.1.4 > > > > > > _______________________________________________ > > barebox mailing list > > [email protected] > > http://lists.infradead.org/mailman/listinfo/barebox > -- -- Best regards, Antony Pavlov _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
