The patch "8bfd06f073c8 state: uint8: add range check for uint8" as applied not correctly to the repository. It was supposed to change the state_uint8_create() function:
| static struct state_variable *state_uint8_create(struct state *state, | | su32 = xzalloc(sizeof(*su32)); | | - param = dev_add_param_int(&state->dev, name, state_set_dirty, | - NULL, &su32->value, "%u", state); | + param = dev_add_param_int(&state->dev, name, state_uint8_set, | + NULL, &su32->value, "%u", su32); but the state_uint32_create() was changed instead, which leads to broken range checks on uint32 variables and no range checks on uint8. This patch fixes the problem. Fixes: 8bfd06f073c8 state: uint8: add range check for uint8 Signed-off-by: Marc Kleine-Budde <[email protected]> --- common/state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/state.c b/common/state.c index 7076f5764d1f..e21fd59a3ee7 100644 --- a/common/state.c +++ b/common/state.c @@ -171,8 +171,8 @@ static struct state_variable *state_uint8_create(struct state *state, su32 = xzalloc(sizeof(*su32)); - param = dev_add_param_int(&state->dev, name, state_set_dirty, - NULL, &su32->value, "%d", state); + param = dev_add_param_int(&state->dev, name, state_uint8_set, + NULL, &su32->value, "%d", su32); if (IS_ERR(param)) { free(su32); return ERR_CAST(param); -- 2.1.4 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
