On Wed, Jan 20, 2016 at 08:46:50AM +0100, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König <[email protected]> > --- > scripts/kwboot.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/scripts/kwboot.c b/scripts/kwboot.c > index 46328d8ed006..61f807d163f7 100644 > --- a/scripts/kwboot.c > +++ b/scripts/kwboot.c > @@ -546,6 +546,49 @@ out: > return rc; > } > > +static void > +kwboot_check_image(unsigned char *img, size_t size) > +{ > + size_t i; > + size_t header_size, image_size; > + unsigned char csum = 0; > + > + switch (img[0x0]) { > + case 0x5a: /* SPI/NOR */ > + case 0x69: /* UART0 */ > + case 0x78: /* SATA */ > + case 0x8b: /* NAND */ > + case 0x9c: /* PCIe */ > + break; > + default: > + printf("Unknown boot source: 0x%hhx\n", img[0x0]); > + } > + > + if (img[0x8] != 1) > + printf("Unknown version: 0x%hhx\n", img[0x8]); > + > + image_size = img[0x4] | (img[0x5] << 8) | > + (img[0x6] << 16) | (img[0x7] << 24); > + > + header_size = (img[0x9] << 16) | img[0xa] | (img[0xb] << 8); > + > + if (header_size + image_size != size) { > + printf("Size mismatch (%zu + %zu != %zu)\n", > + header_size, image_size, size); > + } else { > + for (i = 0; i < header_size; ++i) > + csum += img[i]; > + > + csum -= img[0x1f]; > + > + if (csum != img[0x1f]) > + printf("Checksum mismatch: header: 0x%02hhx, > calculated: 0x%02hhx\n", > + img[0x1f], csum); > + }
Shouldn't these failures have any consequences like exiting the program with an error? > +} > + > + > + Please drop the multiple blank lines. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
