On Mon, 8 Aug 2016 16:15:14 +0200 Lucas Stach <[email protected]> wrote:
> Implement the missing reading of the fixed link parameters from > the devicetree properties. > > Signed-off-by: Lucas Stach <[email protected]> > --- > v2: fix coding style > --- > drivers/net/phy/phy.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c > index 13b832470926..4f228829e510 100644 > --- a/drivers/net/phy/phy.c > +++ b/drivers/net/phy/phy.c > @@ -309,11 +309,14 @@ static struct phy_device > *of_phy_register_fixed_link(struct device_node *np, > > phydev->dev.parent = &edev->dev; > phydev->registered = 1; > - phydev->speed = 1000; > - phydev->duplex = 1; > - phydev->pause = phydev->asym_pause = 0; > phydev->link = 1; > > + if (of_property_read_u32(np, "speed", &phydev->speed)) > + return NULL; phy_device_create() allocated memory for the phydev structure via xzalloc(). with this 'return NULL' we have a memory leak here. > + phydev->duplex = of_property_read_bool(np, "full-duplex"); > + phydev->pause = of_property_read_bool(np, "pause"); > + phydev->asym_pause = of_property_read_bool(np, "asym-pause"); > + > return phydev; > } > > -- > 2.8.1 > > > _______________________________________________ > barebox mailing list > [email protected] > http://lists.infradead.org/mailman/listinfo/barebox -- -- Best regards, Antony Pavlov _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
