Hi Daniel, On Thu, Dec 14, 2017 at 04:51:15PM +0100, Daniel Schultz wrote: > The 'get_ram_size' function can return false values with 1GB RAMs during > warm reset. If a not-existing RAM size will be returned, the fallback > RAM timings get loaded to prevent hangs.
Just continuing with wrong ram size and fallback timing is not really an option. It doesn't help the user and only changes the bug reports you get. Sascha > > Signed-off-by: Daniel Schultz <[email protected]> > --- > arch/arm/boards/phytec-som-am335x/lowlevel.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boards/phytec-som-am335x/lowlevel.c > b/arch/arm/boards/phytec-som-am335x/lowlevel.c > index b1576ee..5030966 100644 > --- a/arch/arm/boards/phytec-som-am335x/lowlevel.c > +++ b/arch/arm/boards/phytec-som-am335x/lowlevel.c > @@ -174,8 +174,9 @@ static noinline void physom_board_init(void *fdt, int > sdram, int module_family) > /* Find the ram size and set up the correct ram timings */ > ramsize = get_ram_size((long *) 0x80000000, SZ_1G); > timing = get_timings_by_size(module_family, ramsize); > + /* In case of a failure, load generic ram timings as fallback */ > if (!timing) > - hang(); > + timing = get_minimal_timings(module_family); > } > > am335x_sdram_init(DDR_IOCTRL, &physom_cmd, > -- > 2.7.4 > > > _______________________________________________ > barebox mailing list > [email protected] > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
