On Sat, Nov 10, 2018 at 08:59:50AM +0100, Oleksij Rempel wrote: > if read_file_2 will fail, s_len will stay uninitialized. > > Signed-off-by: Oleksij Rempel <[email protected]> > --- > commands/keystore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/commands/keystore.c b/commands/keystore.c > index 52c4be263..50a6c8494 100644 > --- a/commands/keystore.c > +++ b/commands/keystore.c > @@ -15,7 +15,7 @@ static int do_keystore(int argc, char *argv[]) > const char *file = NULL; > char *secret_str = NULL; > void *secret; > - int s_len; > + int s_len = 0;
if read_file_2 fails then s_len is also not used. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
