On Fri, Nov 23, 2018 at 02:55:24PM +0100, Rouven Czerwinski wrote: > Michael Tretter <[email protected]> writes: [...] > > +static inline void PUTC_LL(int c) > > +{ > > + void __iomem *base = (void __iomem *)ZYNQMP_DEBUG_LL_UART_BASE; > > + > > + if (readl(base) & ZYNQMP_UART_TXDIS) > > + return; > > + > > + while ((readl(base + ZYNQMP_UART_CHANNEL_STS) & ZYNQMP_UART_STS_TFUL) > > != 0) > > + ; > ^ this should be in the previous line
Is there a coding style for that? I find the semicolon better in a single line to make it more obvious that this is an empty while loop. - Roland > > + > > + writel(c, base + 0x30); > > +} > > + > > +#endif -- Roland Hieber | [email protected] | Pengutronix e.K. | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
