Hi Alexander,
Very nice :) I appreciate lowering the number of defconfigs to build.
Looks mostly fine, two small things:
On Fri, Dec 14, 2018 at 12:27:16PM +0300, Alexander Shiyan wrote:
> +#include <arm/imx51-digi-connectcore-jsk.dts>
> +
> +/ {
> + chosen {
> + stdout-path = &uart1;
> +
> + environment@0 {
> + compatible = "barebox,environment";
> + device-path = &nfc, "partname:env";
> + };
> + };
Some tabs missing here.
> +};
> +
> +&iim {
> + barebox,provide-mac-address = <&fec 1 9>;
> +};
> +
> +&nfc {
> + partition@0 {
> + label = "boot";
> + reg = <0x00000 0x80000>;
> + };
> +
> + partition@1 {
> + label = "env";
> + reg = <0x80000 0x40000>;
> + };
You should add the remaining partitions here aswell and remove
arch/arm/boards/ccxmx51/env/init/mtdparts-nand.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
