On Tue, Jan 08, 2019 at 09:47:04AM +0000, Baeuerle, Florian wrote:
> NAK! NAK!
> 
> There are two terrible mistakes - indeed the patches produce a very 
> reproducible
> environment. Independent of what environment you want, you'd get an empty one.
> 
> Problem 1: a2f3b3d
> it requires ACTION_RECURSE | ACTION_SORT
> 
> Problem 2: f5c0978
> +                     e->dirname = xstrdup(next->d_name);
> should be much more like:
> +                     e->dirname = xstrdup(fileName);
> 
> Sorry for that, problem 2 should really *not* have happened.

Don't worry, it's still in -next and not yet in master.
I squashed your fixups into the broken commits.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

Reply via email to