Hi Christian,
On Tue, Jul 14, 2020 at 11:11:39AM +0200, Christian Mauderer wrote:
> @@ -622,7 +622,8 @@ int bootm_boot(struct bootm_data *bootm_data)
> }
>
> ret = fit_open_image(data->os_fit, data->fit_config, "kernel",
> - &data->fit_kernel, &data->fit_kernel_size);
> + &data->fit_kernel, &data->fit_kernel_size,
> + &data->os_address, &data->os_entry);
bootm has -a and -e options to specify the load address and the entry
point. If given, these should take precedence over the addresses given
in the FIT image.
> int fit_open_image(struct fit_handle *handle, void *configuration,
> const char *name, const void **outdata,
> - unsigned long *outsize)
> + unsigned long *outsize, unsigned long *load,
> + unsigned long *entry)
> {
fit_open_image() has many parameters already and the two new ones are
not always needed or used. I think it's better to make getting the
addresses a separate function, fit_get_load_address() and
fit_get_entry() maybe?
Regards,
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
