On 7/15/20 2:35 PM, Lucas Stach wrote: > Am Mittwoch, den 15.07.2020, 12:10 +0200 schrieb Oleksij Rempel: >> In case the device is a root node, then do not dump it. Otherwise it will be >> a >> mess. > > This is waaay too unspecific for a commit message. What happens without > this patch and how does this patch fix it?
While at it, you could move this patch here to the series start, so bisection can't end on a patch with the messy devinfo output. > > Regards, > Lucas > >> Signed-off-by: Oleksij Rempel <[email protected]> >> --- >> commands/devinfo.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/commands/devinfo.c b/commands/devinfo.c >> index 81956b1cc0..018a7c4167 100644 >> --- a/commands/devinfo.c >> +++ b/commands/devinfo.c >> @@ -99,7 +99,7 @@ static int do_devinfo(int argc, char *argv[]) >> printf("\n"); >> } >> #ifdef CONFIG_OFDEVICE >> - if (dev->device_node) { >> + if (dev->device_node && dev->device_node != of_get_root_node()) >> { >> printf("Device node: %s\n", >> dev->device_node->full_name); >> of_print_nodes(dev->device_node, 0); >> } > > > _______________________________________________ > barebox mailing list > [email protected] > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
