Depending on passed options, uimage may never assign ret a value. Fix this by returning COMMAND_SUCCESS by default.
Reported-by: clang-analyzer-10 Signed-off-by: Ahmad Fatoum <[email protected]> --- commands/uimage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/commands/uimage.c b/commands/uimage.c index 982da7101aa7..fb4df780bdd0 100644 --- a/commands/uimage.c +++ b/commands/uimage.c @@ -19,7 +19,7 @@ static int uimage_flush(void *buf, unsigned int len) static int do_uimage(int argc, char *argv[]) { struct uimage_handle *handle; - int ret; + int ret = 0; int verify = 0; int fd; int opt; @@ -84,7 +84,7 @@ static int do_uimage(int argc, char *argv[]) err: uimage_close(handle); - return ret ? 1 : 0; + return ret ? COMMAND_ERROR : COMMAND_SUCCESS; } BAREBOX_CMD_HELP_START(uimage) -- 2.28.0 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
