On Thu, 15 Oct 2020 15:29:01 +0200, Ahmad Fatoum wrote:
> On 10/15/20 3:20 PM, Michael Tretter wrote:
> > On arm64 the compiler prints the following warning, when the macb driver
> > is enabled:
> >
> > warning: cast from pointer to integer of different size
> >
> > Add the same explicit cast as implemented for all other dma addresses in
> > the macb driver.
> >
> > Fixes: befd110b5922 ("net: macb: init multiple dummy TX queues")
>
> I don't think this qualifies as a fix. You just silence the compiler
> warning you that your truncate the upper 32 bits of your buffer's
> address. This works because your SDRAM's location in physical memory
> is below 4G.
Correct. Which is exactly the same as assumed by the entire driver...
Michael
>
> > Signed-off-by: Michael Tretter <[email protected]>
> > ---
> > drivers/net/macb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> > index fa530cfe8e4c..188dbf2d8c15 100644
> > --- a/drivers/net/macb.c
> > +++ b/drivers/net/macb.c
> > @@ -365,7 +365,7 @@ static int gmac_init_dummy_tx_queues(struct macb_device
> > *macb)
> > MACB_BIT(TX_LAST) | MACB_BIT(TX_USED);
> >
> > for (i = 1; i < num_queues; i++)
> > - gem_writel_queue_TBQP(macb, &macb->gem_q1_descs[0], i - 1);
> > + gem_writel_queue_TBQP(macb, (ulong)macb->gem_q1_descs, i - 1);
> >
> > return 0;
> > }
> >
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
