The SoC init functions return an error code when run on a SoC without
support compiled in. Propagate error codes, so this is reported to the
user.

Signed-off-by: Ahmad Fatoum <[email protected]>
---
 arch/arm/mach-rockchip/rockchip.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/arch/arm/mach-rockchip/rockchip.c 
b/arch/arm/mach-rockchip/rockchip.c
index f0b2484c687b..c185b0cc2b65 100644
--- a/arch/arm/mach-rockchip/rockchip.c
+++ b/arch/arm/mach-rockchip/rockchip.c
@@ -6,14 +6,13 @@
 static int rockchip_init(void)
 {
        if (of_machine_is_compatible("rockchip,rk3188"))
-               rk3188_init();
-       else if (of_machine_is_compatible("rockchip,rk3288"))
-               rk3288_init();
-       else if (of_machine_is_compatible("rockchip,rk3568"))
-               rk3568_init();
-       else
-               pr_err("Unknown rockchip SoC\n");
+               return rk3188_init();
+       if (of_machine_is_compatible("rockchip,rk3288"))
+               return rk3288_init();
+       if (of_machine_is_compatible("rockchip,rk3568"))
+               return rk3568_init();
 
-       return 0;
+       pr_err("Unknown rockchip SoC\n");
+       return -ENODEV;
 }
 postcore_initcall(rockchip_init);
-- 
2.30.2


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

Reply via email to