On Mon, May 29, 2023 at 09:03:52PM +1000, [email protected] wrote: > Hi, > > Thanks for your comments. .. > ... > > > + error = pwm_apply_state(pwm, &state); > > > + > > > + if (stop > 0) { > > > + state.p_enable = false; > > > + error = pwm_apply_state(pwm, &state); > > > + } > > > + > > > + pwm_free(pwm); > > > + > > > + return error; > > > > nit: return 0 > > > > This I didn't change - error is propagating return value of pwm_apply_state() Oh, you're right, sorry
> > I also fixed your other comments for pwm_get (including the somewhat > embarrassing ^S :/ ) > > Cheers > Marc > > >
