Hi Ahmad, On Wed Mar 26, 2025 at 7:52 AM CET, Ahmad Fatoum wrote: > Hello Jules, > > On 25.03.25 15:36, Jules Maselbas wrote: >> Signed-off-by: Jules Maselbas <[email protected]> >> --- >> drivers/tee/optee/rpmb.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/tee/optee/rpmb.c b/drivers/tee/optee/rpmb.c >> index cdc8afc1a4..ca60f3cf3d 100644 >> --- a/drivers/tee/optee/rpmb.c >> +++ b/drivers/tee/optee/rpmb.c >> @@ -5,6 +5,7 @@ >> >> #define pr_fmt(fmt) "optee-rpmb: " fmt >> >> +#include <common.h> > > Is this only for ARRAY_SIZE? Then I'd prefer we include <linux/kernel.h> or Yes, this is for ARRAY_SIZE > <linux/array_size.h>, because we generally want to cut down on use of > <common.h>, if only to reduce compile time a bit. okay
> Also, please send fixups without a reply-to for patches that are already > applied. > This makes it less likely to be missed IMO. ack > Cheers, > Ahmad > > > >> #include <mci.h> >> >> #include "optee_msg.h"
