On Mon, Apr 07, 2025 at 09:59:13AM +0200, Ahmad Fatoum wrote:
> On 07.04.25 09:29, Sascha Hauer wrote:
> > When ratp command handling was introduced in ff612b866f301 ("ratp:
> > implement generic command support") we had an explicit 64bit alignment
>
> s/64bit/64 byte/
FIxed while applying, thanks
Sascha
>
> > for the ratp command array in sandbox. This was removed in 52e5c35671
> > ("X86: lds: remove unnecessary alignments"). With this it can happen
> > that the ratp command section starts at a non 64bit aligned address, but
> > the first command in that section will be placed at the first 64bit
> > boundary. __barebox_ratp_cmd_start will no longer point to the actual
> > command then and the array iteration fails.
> >
> > Just drop the wrong alignment annotation.
> >
> > Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de>
> > ---
> > include/ratp_bb.h | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/include/ratp_bb.h b/include/ratp_bb.h
> > index 418be6fe7b..c6c7c4bc23 100644
> > --- a/include/ratp_bb.h
> > +++ b/include/ratp_bb.h
> > @@ -57,12 +57,7 @@ struct ratp_command {
> > int req_len,
> > struct ratp_bb **rsp,
> > int *rsp_len);
> > -}
> > -#ifdef __x86_64__
> > -/* This is required because the linker will put symbols on a 64 bit
> > alignment */
> > -__attribute__((aligned(64)))
> > -#endif
> > -;
> > +};
> >
> > #define BAREBOX_RATP_CMD_START(_name)
> > \
> > extern const struct ratp_command __barebox_ratp_cmd_##_name;
> > \
> >
>
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
