Hi, On 07.07.25 07:53, Gwenhael Goavec-Merou wrote: > From: Gwenhael Goavec-Merou <gwenhael.goavec-me...@trabucayre.com> > > As mentionned in [1] MMC sometime fails to be initialized/ is not > working with this type of error: > > arasan-sdhci e0100000....@e0100000.of: registered as mmc0 > malloc space: 0x17e00000 -> 0x1fdfffff (size 128 MiB) > arasan-sdhci e0100000....@e0100000.of: error while transferring data for > command 6 > arasan-sdhci e0100000....@e0100000.of: state = 0x01ff0202 , interrupt = > 0x00208000 > mmc0: Card's startup fails with -74 > barebox-environment chosen:environment-sd.of: probe failed: No such file or > directory > environment load /dev/env0: No such file or directory > > This patch adds SDIO clck configuration allowing to have a valid MMC > clock frequency. > > [1] > https://lore.barebox.org/barebox/vi1pr02mb4429606e3b06d0f53d2b4175ab...@vi1pr02mb4429.eurprd02.prod.outlook.com/T/#m1cb8598da4741c0b7a41944e1aecef373dd74319
Same comment as on v1, I'd suggest as commit message title: ARM: zynq: zed: add SDIO clk frequency configuration I am wondering why this is needed when we seem to have a clock driver for the platform, but your workaround looks ok: Acked-by: Ahmad Fatoum <a.fat...@pengutronix.de> Thanks, Ahmad > > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-me...@trabucayre.com> > --- > arch/arm/boards/avnet-zedboard/lowlevel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boards/avnet-zedboard/lowlevel.c > b/arch/arm/boards/avnet-zedboard/lowlevel.c > index 605aab783a..b7a98f5a82 100644 > --- a/arch/arm/boards/avnet-zedboard/lowlevel.c > +++ b/arch/arm/boards/avnet-zedboard/lowlevel.c > @@ -241,6 +241,7 @@ static void avnet_zedboard_ps7_init(void) > /* poor mans clkctrl */ > writel(0x00001403, ZYNQ_CLOCK_CTRL_BASE + ZYNQ_UART_CLK_CTRL); > writel(0x00000101, ZYNQ_CLOCK_CTRL_BASE + ZYNQ_LQSPI_CLK_CTRL); > + writel(0x00001401, ZYNQ_CLOCK_CTRL_BASE + ZYNQ_SDIO_CLK_CTRL); > > /* GEM0 */ > writel(0x00000001, 0xf8000138); -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
